Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Support forward HAProxyMessage for Multi Protocol server. #7061

Closed
1 task done
dingshuangxi888 opened this issue Jul 21, 2023 · 0 comments · Fixed by #7062
Closed
1 task done

[Enhancement] Support forward HAProxyMessage for Multi Protocol server. #7061

dingshuangxi888 opened this issue Jul 21, 2023 · 0 comments · Fixed by #7062
Labels
type/enhancement

Comments

@dingshuangxi888
Copy link
Contributor

Before Creating the Enhancement Request

  • I have confirmed that this should be classified as an enhancement rather than a bug/feature.

Summary

When we want to support both Remoting protocol and gRPC protocol on the same port, and enable Proxy Protocol, the information for that protocol will be lost during data forwarding. Therefore, we need to re-add the information for that protocol during forwarding.

Motivation

In a multi-protocol environment, it is necessary to forward Proxy Protocol data simultaneously when forwarding other protocols.

Describe the Solution You'd Like

  1. In a multi-protocol service, when determining that a request is using gRPC protocol, data forwarding is required.
  2. Before forwarding, it is necessary to determine whether there is Proxy Protocol data.
  3. If there is, these data should be repackaged as Proxy Protocol and forwarded first, and then the business-related data can be forwarded.
  4. During this process, compatibility with SSL protocol encryption needs to be considered.

Describe Alternatives You've Considered

No.

Additional Context

No response
@dingshuangxi888 dingshuangxi888 mentioned this issue Jul 21, 2023
Merged
lollipopjin pushed a commit that referenced this issue Jul 21, 2023
@dingshuangxi888
[ISSUE #7061] Support forward HAProxyMessage for Multi Protocol serve…
90c5382 
…r. (#7062)

* Support dynamic modification of grpc tls mode to improve the scalability of ProtocolNegotiator

* Support dynamic modification of grpc tls mode to improve the scalability of ProtocolNegotiator

* [ISSUE #6866] Move the judgment logic of grpc TLS mode to improve the scalability of ProtocolNegotiator

* [ISSUE #6866] Move the judgment logic of grpc TLS mode to improve the scalability of ProtocolNegotiator

* [ISSUE #6866] Move the judgment logic of grpc TLS mode to improve the scalability of ProtocolNegotiator

* [ISSUE #6866] Move the judgment logic of grpc TLS mode to improve the scalability of ProtocolNegotiator

* Support proxy protocol for gRPC server.

* Support proxy protocol for gRPC server.

* Support proxy protocol for gRPC server.

* Support proxy protocol for gRPC server.

* Support proxy protocol for gRPC server.

* Support proxy protocol for gRPC and Remoting server.

* 回滚netty的升级

* Support proxy protocol for gRPC and Remoting server.

* Support proxy protocol for gRPC and Remoting server.

* Support proxy protocol for gRPC and Remoting server.

* add grpc-netty-codec-haproxy in bazel

* add grpc-netty-codec-haproxy in bazel

* Support proxy protocol for gRPC and Remoting server.

* Fix Test

* add grpc-netty-codec-haproxy in bazel

* add ProxyProtocolTest for Remoting

* Support HAProxyMessage forward for multi protocol server.

---------

Co-authored-by: 徒钟 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ISSUE #7061] Support forward HAProxyMessage for Multi Protocol server.
1 participant
@dingshuangxi888