[Enhancement] In ExpressionForRetryMessageFilter, iff the subscription type is TAG, we can return true directly.

[HScarb]

Before Creating the Enhancement Request

• I have confirmed that this should be classified as an enhancement rather than a bug/feature.

Summary

In ExpressionForRetryMessageFilter, when isRetryTopic is true and the subscription type is TAG, it won't return true now and will decode message properties, which decreases the performance.

rocketmq/broker/src/main/java/org/apache/rocketmq/broker/filter/ExpressionForRetryMessageFilter.java

Lines 48 to 67 in 7996ec3

	boolean isRetryTopic = subscriptionData.getTopic().startsWith(MixAll.RETRY_GROUP_TOPIC_PREFIX);
	if (!isRetryTopic && ExpressionType.isTagType(subscriptionData.getExpressionType())) {
	return true;
	}
	ConsumerFilterData realFilterData = this.consumerFilterData;
	Map<String, String> tempProperties = properties;
	boolean decoded = false;
	if (isRetryTopic) {
	// retry topic, use original filter data.
	// poor performance to support retry filter.
	if (tempProperties == null && msgBuffer != null) {
	decoded = true;
	tempProperties = MessageDecoder.decodeProperties(msgBuffer);
	}
	String realTopic = tempProperties.get(MessageConst.PROPERTY_RETRY_TOPIC);
	String group = subscriptionData.getTopic().substring(MixAll.RETRY_GROUP_TOPIC_PREFIX.length());
	realFilterData = this.consumerFilterManager.get(realTopic, group);
	}

Motivation

Enhance ExpressionForRetryMessageFilter performance. We don't need to decode message properties when isRetryTopic is true and the subscription type is TAG. Because tag subscriptions will be filtered on the client side.

Describe the Solution You'd Like

Return true directly when the subscription type is TAG.

Describe Alternatives You've Considered

none

Additional Context

No response