Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] The logic of coldDataCheckService() needs to be optimized #7013

Closed
3 tasks done
GenerousMan opened this issue Jul 11, 2023 · 0 comments · Fixed by #7014
Closed
3 tasks done

[Enhancement] The logic of coldDataCheckService() needs to be optimized #7013

GenerousMan opened this issue Jul 11, 2023 · 0 comments · Fixed by #7014

Comments

@GenerousMan
Copy link
Contributor

Before Creating the Bug Report

  • I found a bug, not just asking a question, which should be created in GitHub Discussions.

  • I have searched the GitHub Issues and GitHub Discussions of this repository and believe that this is not a duplicate.

  • I have confirmed that this bug belongs to the current repository, not other repositories of RocketMQ.

Runtime platform environment

Mac, M1

RocketMQ version

latest

JDK Version

No response

Describe the Bug

Regardless of whether the cold read control switch is turned on, initPageSize() will be executed. However in some cases it may trigger an error.

Steps to Reproduce

turn off the related switch:
coldDataScanEnable = false
coldDataFlowControlEnable = false

then start the broker, there will still be such log in store.log:
2023-07-03 13:54:01 INFO main - initPageSize pageSize: 4096

However, this discussion shows that in some cases, it will lead to an error:
#7007

What Did You Expect to See?

The initialization should only be triggered after the switch is turned on.

What Did You See Instead?

then start the broker, there is such log in store.log:
2023-07-03 13:54:01 INFO main - initPageSize pageSize: 4096

Additional Context

No response

@RongtongJin RongtongJin changed the title [Bug] The logic of coldDataCheckService() needs to be optimized [Enhancement] The logic of coldDataCheckService() needs to be optimized Jul 11, 2023
RongtongJin pushed a commit that referenced this issue Jul 11, 2023
* polish coldCtrl

* remove the catch.
lizhimins pushed a commit to lizhimins/rocketmq that referenced this issue Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants