Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] isEnableBatchPush can not be changed since the setter name is wrong #6800

Closed
3 tasks done
absolute8511 opened this issue May 23, 2023 · 1 comment · Fixed by #6801
Closed
3 tasks done

[Bug] isEnableBatchPush can not be changed since the setter name is wrong #6800

absolute8511 opened this issue May 23, 2023 · 1 comment · Fixed by #6801
Labels

Comments

@absolute8511
Copy link
Contributor

Before Creating the Bug Report

  • I found a bug, not just asking a question, which should be created in GitHub Discussions.

  • I have searched the GitHub Issues and GitHub Discussions of this repository and believe that this is not a duplicate.

  • I have confirmed that this bug belongs to the current repository, not other repositories of RocketMQ.

Runtime platform environment

Linux

RocketMQ version

4.9.x

JDK Version

No response

Describe the Bug

isEnableBatchPush can not be changed since the setter name is wrong

Steps to Reproduce

  1. add isEnableBatchPush=true in the broker.properties config
  2. use enableDLegerCommitLog=true
  3. saw batch push is not enabled in dledger mode and the var isEnableBatchPush in MessageStoreConfig still false

using test to reproducer

@Test
    public void testBrokerControllerConfigInit() throws Exception {
        Properties properties = new Properties();
        properties.setProperty("isEnableBatchPush", "true");
        MessageStoreConfig messageStoreConfig = new MessageStoreConfig();
        MixAll.properties2Object(properties, messageStoreConfig);
        assertThat(messageStoreConfig.isEnableBatchPush()).isTrue();
    }

What Did You Expect to See?

isEnableBatchPush should be changed after set isEnableBatchPush=true in the broker.properties config

What Did You See Instead?

isEnableBatchPush did not change in the MessageStoreConfig

Additional Context

No response

@cserwen
Copy link
Member

cserwen commented May 25, 2023

Actually, set enableBatchPush as true can work.

RongtongJin pushed a commit that referenced this issue Jun 12, 2023
…atchPush (#6801)

* fix: wrong setter for config isEnableBatchPush

Change-Id: I1ebf4748c26c42efb058c11a8b5084b69213892c

* fix: change isEnableBatchPush to enableBatchPush

Change-Id: I13db49a30841fe5ff9a548f02afa0cc272ba027d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants