-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE #570] ASoC connect runtime optimization: CLI #622
Conversation
} | ||
return ""; | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Optional) newline here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated all
|
||
与RocketMQ中的mqadmin类似,使用简洁的CLI命令实现增加,删除,查看connector等功能 | ||
|
||
在rocketmq-connect\tools目录下,运行`sh connectAdmin` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AFAIK this might not be the newest directory
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated cli
</dependencies> | ||
|
||
|
||
</project> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here, optional
throw new SubCommandException(this.getClass().getSimpleName() + " command failed", e); | ||
} | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
op
throw new SubCommandException(this.getClass().getSimpleName() + " command failed", e); | ||
} | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
op
} | ||
return ""; | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
op
httpPort=8081 | ||
|
||
# RocketMQ Connect Runtime Addr | ||
httpAddr=localhost |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
op
<scope>runtime</scope> | ||
</dependencySet> | ||
</dependencySets> | ||
</assembly> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
op
@@ -136,6 +136,7 @@ public KeyValue configs() { | |||
try { | |||
Collection<SourceDataEntry> toSendEntries = sourceTask.poll(); | |||
if (null != toSendEntries && toSendEntries.size() > 0) { | |||
log.info("send records"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some very bad log conventions in the runtime and I apologize for that, but we need to try to make log messages clear ~ This might be a log added during debug process so we might not need it ~ I'll probably refactor the logs in externals (as some of them looks messy, with some needed logs missing) it would be great if you're willing to help :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated
@@ -80,7 +80,6 @@ public void doRebalance() { | |||
List<String> curAliveWorkers = clusterManagementService.getAllAliveWorkers(); | |||
Map<String, ConnectKeyValue> curConnectorConfigs = configManagementService.getConnectorConfigs(); | |||
Map<String, List<ConnectKeyValue>> curTaskConfigs = configManagementService.getTaskConfigs(); | |||
log.info("[ISSUE #2027] The connectorConfigs are:" + curConnectorConfigs.toString() + " with timestamp :" + System.currentTimeMillis()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job here~
What is the purpose of the change
XXXXX
Brief changelog
XX
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice,
it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR
.[ISSUE #123] Fix UnknownException when host config not exist
. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle
to make sure basic checks pass. Runmvn clean install -DskipITs
to make sure unit-test pass. Runmvn clean test-compile failsafe:integration-test
to make sure integration-test pass.