[ISSUE #570] ASoC connect runtime optimization: CLI #622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imaffe
reviewed
Aug 13, 2020
| } | ||
| return ""; | ||
| } | ||
| } |
|
|
||
| 与RocketMQ中的mqadmin类似，使用简洁的CLI命令实现增加，删除，查看connector等功能 | ||
|
|
||
| 在rocketmq-connect\tools目录下，运行`sh connectAdmin` |
There was a problem hiding this comment.
AFAIK this might not be the newest directory
| </dependencies> | ||
|
|
||
|
|
||
| </project> |
| throw new SubCommandException(this.getClass().getSimpleName() + " command failed", e); | ||
| } | ||
| } | ||
| } |
| throw new SubCommandException(this.getClass().getSimpleName() + " command failed", e); | ||
| } | ||
| } | ||
| } |
| } | ||
| return ""; | ||
| } | ||
| } |
| httpPort=8081 | ||
|
|
||
| # RocketMQ Connect Runtime Addr | ||
| httpAddr=localhost |
| <scope>runtime</scope> | ||
| </dependencySet> | ||
| </dependencySets> | ||
| </assembly> |
| @@ -136,6 +136,7 @@ public KeyValue configs() { | |||
| try { | |||
| Collection<SourceDataEntry> toSendEntries = sourceTask.poll(); | |||
| if (null != toSendEntries && toSendEntries.size() > 0) { | |||
| log.info("send records"); | |||
There was a problem hiding this comment.
I left some very bad log conventions in the runtime and I apologize for that, but we need to try to make log messages clear ~ This might be a log added during debug process so we might not need it ~ I'll probably refactor the logs in externals (as some of them looks messy, with some needed logs missing) it would be great if you're willing to help :)
| @@ -80,7 +80,6 @@ public void doRebalance() { | |||
| List<String> curAliveWorkers = clusterManagementService.getAllAliveWorkers(); | |||
| Map<String, ConnectKeyValue> curConnectorConfigs = configManagementService.getConnectorConfigs(); | |||
| Map<String, List<ConnectKeyValue>> curTaskConfigs = configManagementService.getTaskConfigs(); | |||
| log.info("[ISSUE #2027] The connectorConfigs are:" + curConnectorConfigs.toString() + " with timestamp :" + System.currentTimeMillis()); | |||
odbozhou
pushed a commit
that referenced
this pull request
Mar 1, 2022
odbozhou
pushed a commit
that referenced
this pull request
Mar 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
XXXXX
Brief changelog
XX
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice,
it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.[ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyleto make sure basic checks pass. Runmvn clean install -DskipITsto make sure unit-test pass. Runmvn clean test-compile failsafe:integration-testto make sure integration-test pass.