Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RATIS-1942. GrpcLogAppender has ILLEGAL TRANSITION: STARTING -> STARTING #994

Merged
merged 2 commits into from
Dec 14, 2023

Conversation

adoroszlai
Copy link
Contributor

@adoroszlai adoroszlai commented Dec 13, 2023

What changes were proposed in this pull request?

Assign local address to new peers being added to the cluster.

https://issues.apache.org/jira/browse/RATIS-1942

How was this patch tested?

Compared 10x10 runs of TestRetryCacheWithGrpc with and without the patch.

without patch: 13/100 failures, 10/13 failure logs had STARTING -> STARTING:
https://github.com/adoroszlai/ratis/actions/runs/7199041920

$ grep -cr 'STARTING -> STARTING' | sort -g
1/iteration2/ratis-test/org.apache.ratis.grpc.TestRetryCacheWithGrpc-output.txt:1223
2/iteration1/ratis-test/org.apache.ratis.grpc.TestRetryCacheWithGrpc-output.txt:1457
2/iteration3/ratis-test/org.apache.ratis.grpc.TestRetryCacheWithGrpc-output.txt:1284
2/iteration9/ratis-test/org.apache.ratis.grpc.TestRetryCacheWithGrpc-output.txt:1374
3/iteration7/ratis-test/org.apache.ratis.grpc.TestRetryCacheWithGrpc-output.txt:1190
6/iteration10/ratis-test/org.apache.ratis.grpc.TestRetryCacheWithGrpc-output.txt:1215
9/iteration6/ratis-test/org.apache.ratis.grpc.TestRetryCacheWithGrpc-output.txt:1448
9/iteration8/ratis-test/org.apache.ratis.grpc.TestRetryCacheWithGrpc-output.txt:1440
10/iteration1/ratis-test/org.apache.ratis.grpc.TestRetryCacheWithGrpc-output.txt:1507

with patch, no STARTING -> STARTING:
https://github.com/adoroszlai/ratis/actions/runs/7198991194

CI:
https://github.com/adoroszlai/ratis/actions/runs/7198887876

@adoroszlai adoroszlai self-assigned this Dec 13, 2023
@adoroszlai adoroszlai marked this pull request as ready for review December 13, 2023 20:01
Copy link
Contributor

@szetszwo szetszwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 the change looks good.

@adoroszlai adoroszlai requested a review from szetszwo December 14, 2023 08:05
@szetszwo szetszwo merged commit 2728ba8 into apache:master Dec 14, 2023
10 checks passed
@adoroszlai adoroszlai deleted the RATIS-1942 branch December 14, 2023 16:30
@adoroszlai
Copy link
Contributor Author

Thanks @szetszwo for review, suggestions on how to change LifeCycle, and merging it.

symious pushed a commit to symious/ratis that referenced this pull request Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants