Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RATIS-1970. Add junit 5 dependencies in ratis-common. #993

Merged
merged 3 commits into from
Dec 19, 2023

Conversation

nandakumar131
Copy link
Contributor

What changes were proposed in this pull request?

Junit 5 dependencies are added to the appropriate pom files.

What is the link to the Apache JIRA

RATIS-1970

How was this patch tested?

Existing unit tests.

Copy link
Contributor

@adoroszlai adoroszlai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nandakumar131 for the patch, LGTM.

@adoroszlai adoroszlai requested a review from szetszwo December 13, 2023 16:06
@szetszwo
Copy link
Contributor

@nandakumar131 , thanks a lot for working on JUnit5 migration! For the dependencies, let's add them when they are needed (i.e. add them with the tests). We minimize the dependencies because Ratis is a library. We should make it easier to be consumed.

For JUnit5 migration, we may start with ratis-common since it only has a few tests. It can show how the migration works.

@nandakumar131
Copy link
Contributor Author

Thanks for the review @adoroszlai & @szetszwo.

@szetszwo, sure. will do.

FYI: The scope of the junit dependencies are of scope test, so it will not be part of Ratis's transitive dependencies.

@nandakumar131
Copy link
Contributor Author

@szetszwo, I have been working on limiting the changes just to ratis-common, but the test compilation started failing on ratis-server, ratis-test & ratis-examples as they extend BaseTest from ratis-common.

I will try to limit the changes on each PR to make the review process easier.

This PR will only update the parent pom.xml and ratis-common's pom.xml

Test-case changes will happen in follow-up PRs.

@szetszwo
Copy link
Contributor

FYI: The scope of the junit dependencies are of scope test, so it will not be part of Ratis's transitive dependencies.

@nandakumar131 , I understand that the test dependencies are not transitive. That's a good point!

It is usually hard to remove dependencies. So I really oppose adding unused dependencies. Moreover, we have to handle it in case of CVEs.

Please include some change to use the dependencies in this pull requests.

Copy link
Contributor

@szetszwo szetszwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 the change looks good.

@szetszwo szetszwo merged commit 0269873 into apache:master Dec 19, 2023
10 checks passed
@szetszwo szetszwo changed the title RATIS-1970. Add junit 5 dependencies. RATIS-1970. Add junit 5 dependencies in ratis-common. Dec 19, 2023
@nandakumar131 nandakumar131 deleted the RATIS-1970 branch December 20, 2023 03:51
symious pushed a commit to symious/ratis that referenced this pull request Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants