-
Notifications
You must be signed in to change notification settings - Fork 414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RATIS-931. Fixed Add a raft group to all peers currently registered #93
base: master
Are you sure you want to change the base?
Conversation
pull from apache ratis
…l group peers, where the group peers are not all peers currently registered
You can open a jira at https://issues.apache.org/jira/projects/RATIS/issues, and add the jira number in the Pull Request title. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we rename the member peers
to be allKnownPeers
or similar? Something to try to prevent such an error in the future.
What about a test? Did you try to write a unit test to catch this? I think having 4 available workers, create a log, and then look at the raft groups and see that it has 4 members instead of 3 would work.
Sorry, it took so long to reply to you. about the log service, it is okay to verify according to the document (because the number of worker nodes is equal to the number of new raft groups), but when more than 3 worker nodes are started, a log is created at the time, the metadata service will broadcast the addition of Raft groups to unnecessary nodes outside the new raft group. |
fixed In the log service, when creating a log, add a raft group to all group peers, where the group peers are not all peers currently registered