Skip to content

RATIS-1547. Make GrpcClientProtocolService and log to public #617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
captainzmc wants to merge 1 commit into from
Closed

RATIS-1547. Make GrpcClientProtocolService and log to public #617

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ratis-grpc/src/main/java/org/apache/ratis/grpc/server/GrpcClientProtocolService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,8 @@
import java.util.function.Consumer;
import java.util.function.Supplier;

class GrpcClientProtocolService extends RaftClientProtocolServiceImplBase {
private static final Logger LOG = LoggerFactory.getLogger(GrpcClientProtocolService.class);
public class GrpcClientProtocolService extends RaftClientProtocolServiceImplBase {
public static final Logger LOG = LoggerFactory.getLogger(GrpcClientProtocolService.class);
Comment on lines +51 to +52
Copy link
Contributor

@szetszwo szetszwo Mar 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@captainzmc , sorry that GrpcClientProtocolService is not a public API. We should not change it for an Ozone unit test. We should fix the test instead.

Copy link
Contributor

@adoroszlai adoroszlai Mar 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also encountered compile error while trying recent Ratis changes (RATIS-1515, etc.) with Ozone. But I think exposing LOG as public only for Ozone test is bad practice. We may be able to improve TestRatisPipelineLeader by using custom retry policy.


private static class PendingOrderedRequest implements SlidingWindow.ServerSideRequest<RaftClientReply> {
private final RaftClientRequest request;
Expand Down