RATIS-1356. NotifyInstallSnapshot during SetConfiguration has leader … #460
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Fixed CI. Test failing in CI, is passing locally. |
Contributor
Author
|
Opened a new Jira As these failures are seen in other PR runs also. |
Contributor
|
The test failures are not related and will be addressed in a new PR. Merging this as this is required for SCM HA in apache/ozone#2155. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…info missing.
What changes were proposed in this pull request?
Use when raftconf does not have any peer info, use leader info from InstallSnapshotRequestProto.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/RATIS-1356
How was this patch tested?
(Please explain how this patch was tested. Ex: unit tests, manual tests)
Updated test to not pass peer info during raft server star in raftgroup.
Also tested SCM-HA with fix now installSnapshot which happens during setConf is getting correct leaderInfo, previously used to get "".