Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RATIS-2248. Rename CI workflows to .yaml #1220

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

adoroszlai
Copy link
Contributor

What changes were proposed in this pull request?

Rename CI workflows to .yaml as suggested in #1219 (review)

https://issues.apache.org/jira/browse/RATIS-2248

How was this patch tested?

https://github.com/adoroszlai/ratis/actions/runs/13257613914

@adoroszlai adoroszlai added the CI label Feb 11, 2025
@adoroszlai adoroszlai self-assigned this Feb 11, 2025
Copy link
Contributor

@szetszwo szetszwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adoroszlai , thanks a lot for working on this!

There are two more cases:

-- ./.github/workflows/post-commit.yml ----------------------------------------
 32:     uses: ./.github/workflows/ci.yml
   1 occurrence(s)
-- ./dev-support/checks/shellcheck.sh -----------------------------------------
 29:   | grep -v -e target/ -e node_modules/ -e '\.\(ico\|py\|yml\)$' \
   1 occurrence(s)

@adoroszlai
Copy link
Contributor Author

Thanks @szetszwo for the review.

-- ./.github/workflows/post-commit.yml ----------------------------------------
 32:     uses: ./.github/workflows/ci.yml
   1 occurrence(s)

post-commit.yml no longer exists (was renamed), so this must be some leftover from master. The PR also changes the reference to ci.yml.

-- ./dev-support/checks/shellcheck.sh -----------------------------------------
 29:   | grep -v -e target/ -e node_modules/ -e '\.\(ico\|py\|yml\)$' \
   1 occurrence(s)

shellcheck.sh is unused, I'll file a task to remove it.

Copy link
Contributor

@szetszwo szetszwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 the change looks good.

@adoroszlai adoroszlai merged commit bbe20b3 into apache:master Feb 11, 2025
13 checks passed
@adoroszlai adoroszlai deleted the RATIS-2248 branch February 11, 2025 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants