Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RATIS-2215. Bump maven-remote-resources-plugin to 3.3.0 #1208

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

adoroszlai
Copy link
Contributor

What changes were proposed in this pull request?

  • Bump maven-remote-resources-plugin to 3.3.0, which fixes an intermittent reproducibility problem (MRRESOURCES-150).
  • Replace - with _ in variable names in the templates, because - is causes error with newer versions of the plugin. (BTW, are these templates inherited from Hadoop? Most of the dependencies mentioned seem to be unused in Ratis.)

https://issues.apache.org/jira/browse/RATIS-2215

How was this patch tested?

CI:
https://github.com/adoroszlai/ratis/actions/runs/12657963122

@adoroszlai adoroszlai self-assigned this Jan 7, 2025
@adoroszlai adoroszlai requested a review from szetszwo January 7, 2025 20:07
@szetszwo
Copy link
Contributor

szetszwo commented Jan 7, 2025

... are these templates inherited from Hadoop? Most of the dependencies mentioned seem to be unused in Ratis.

Previously, the ratis-hadoop-rpc module was in Ratis. It should be the reason.

Copy link
Contributor

@szetszwo szetszwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 the change looks good.

@adoroszlai adoroszlai merged commit 17c9652 into apache:master Jan 8, 2025
13 checks passed
@adoroszlai adoroszlai deleted the RATIS-2215 branch January 8, 2025 04:19
@adoroszlai
Copy link
Contributor Author

Thanks @szetszwo for the review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants