Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RATIS-2168. Support custom gRPC services. #1169

Merged
merged 2 commits into from
Oct 17, 2024
Merged

RATIS-2168. Support custom gRPC services. #1169

merged 2 commits into from
Oct 17, 2024

Conversation

szetszwo
Copy link
Contributor

OneSizeFitsQuorum
OneSizeFitsQuorum approved these changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@OneSizeFitsQuorum OneSizeFitsQuorum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Only one minor issue~

ratis-grpc/pom.xml Outdated
@@ -53,6 +53,11 @@
<scope>test</scope>
<type>test-jar</type>
</dependency>

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove empty line?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, thanks a lot for reviewing this!

@szetszwo szetszwo merged commit e96ed1a into apache:master Oct 17, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OneSizeFitsQuorum OneSizeFitsQuorum OneSizeFitsQuorum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@szetszwo @OneSizeFitsQuorum