RANGER-5312: authz-embedded #696
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mneethiraj
requested review from
Copilot,
kumaab,
pradeepagrawal8184,
rameeshm,
spolavarpau1 and
vperiasamy
There was a problem hiding this comment.
Pull Request Overview
This pull request implements a RangerAuthorizer with embedded policy engine for local, in-process authorization without requiring external Ranger admin service communication.
- Adds authz-embedded module with RangerEmbeddedAuthorizer implementation
- Introduces RangerAuthzConfig for flexible configuration handling
- Updates Maven build to include the new authz-embedded module
Reviewed Changes
Copilot reviewed 38 out of 38 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| pom.xml | Version downgrades and module addition |
| authz-embedded/pom.xml | Module configuration with required dependencies |
| authz-embedded/src/main/java/org/apache/ranger/authz/embedded/*.java | Core embedded authorizer implementation |
| authz-embedded/src/test/java/org/apache/ranger/authz/embedded/*.java | Unit tests for embedded authorization functionality |
| authz-embedded/src/test/resources/ | Test data files for S3 and Hive authorization scenarios |
| agents-common/src/test/resources/policyengine/ | Updated test files removing unused ACL fields |
| agents-common/src/test/java/org/apache/ranger/plugin/policyengine/TestPolicyACLs.java | Enhanced ACL testing logic |
| agents-common/src/main/java/org/apache/ranger/plugin/policyengine/gds/*.java | GDS evaluator improvements for ACL handling |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
authz-embedded/src/test/resources/test_s3/tests_multi_authz.json
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1,24 @@ | |||
| { | |||
| "serviceName":"dev_s3", "tagVersion":2, | |||
There was a problem hiding this comment.
The serviceName is set to 'dev_s3' but this is a Hive test configuration file. It should be 'dev_hive' to match the context.
Suggested change
| "serviceName":"dev_s3", "tagVersion":2, | |
| "serviceName":"dev_hive", "tagVersion":2, |
Copilot uses AI. Check for mistakes.
authz-embedded/src/test/java/org/apache/ranger/authz/embedded/TestEmbeddedAuthorizer.java
Outdated
Show resolved
Hide resolved
authz-embedded/src/test/java/org/apache/ranger/authz/embedded/TestEmbeddedAuthorizer.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
RangerAuthorizer implementation using embedded policy engine, which performs authorization locally i.e. in-process.
How was this patch tested?
added unit tests