[pulsar-client] Add support to load tls certs/key dynamically from inputstream #6760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdhabalia
assigned merlimat, sijie, jiazhai, codelipenghui and rdhabalia and unassigned merlimat, sijie, rdhabalia, jiazhai and codelipenghui
rdhabalia
force-pushed
the
ssl_client_auth
branch
from
7c929c6
to
13c1e2d
Compare
jiazhai
reviewed
Apr 18, 2020
| return privateKey; | ||
| } | ||
|
|
||
| //TODO: check if bufferReader should be closed or not |
There was a problem hiding this comment.
Yes, fixed it. actually user provided stream can be read multiple times by multiple connections so, pulsar-client needs a stream that can be marked and reset. So, I changed interface with ByteArrayInputStream to support reading same provided stream multiple times.
jiazhai
approved these changes
Apr 20, 2020
sijie
approved these changes
Apr 20, 2020
|
/pulsarbot run-failure-checks |
1 task
|
/pulsarbot run-failure-checks |
jiazhai
pushed a commit
that referenced
this pull request
May 8, 2020
…putstream (#6760) ### Motivation Right now, Pulsar-client provides tls authentication support and default TLS provider `AuthenticationTls` expects file path of cert and key files. However, there are usescases where it will be difficult for user-applications to store certs/key file locally for tls authentication. eg: 1. Applications running on docker or K8s containers will not have certs at defined location and app uses KMS or various key-vault system whose API return streams of certs. 2. Operationally hard to manage key rotation in containers 3. Need to avoid storing key/trust store files on file system for stronger security Therefore, it's good to have mechanism in default `AuthenticationTls` provider to read certs from memory/stream without storing certs on file-system. ### Modification Add Stream support in `AuthenticationTls` to provide X509Certs and PrivateKey which also performs auto-refresh when stream changes in a given provider. ``` AuthenticationTls auth = new AuthenticationTls(certStreamProvider, keyStreamProvider); ``` It will be also address: #5241 (cherry picked from commit 3b48df1)
huangdx0726
pushed a commit
to huangdx0726/pulsar
that referenced
this pull request
Aug 24, 2020
…putstream (apache#6760) ### Motivation Right now, Pulsar-client provides tls authentication support and default TLS provider `AuthenticationTls` expects file path of cert and key files. However, there are usescases where it will be difficult for user-applications to store certs/key file locally for tls authentication. eg: 1. Applications running on docker or K8s containers will not have certs at defined location and app uses KMS or various key-vault system whose API return streams of certs. 2. Operationally hard to manage key rotation in containers 3. Need to avoid storing key/trust store files on file system for stronger security Therefore, it's good to have mechanism in default `AuthenticationTls` provider to read certs from memory/stream without storing certs on file-system. ### Modification Add Stream support in `AuthenticationTls` to provide X509Certs and PrivateKey which also performs auto-refresh when stream changes in a given provider. ``` AuthenticationTls auth = new AuthenticationTls(certStreamProvider, keyStreamProvider); ``` It will be also address: apache#5241
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Right now, Pulsar-client provides tls authentication support and default TLS provider
AuthenticationTlsexpects file path of cert and key files. However, there are usescases where it will be difficult for user-applications to store certs/key file locally for tls authentication.eg:
Therefore, it's good to have mechanism in default
AuthenticationTlsprovider to read certs from memory/stream without storing certs on file-system.Modification
Add Stream support in
AuthenticationTlsto provide X509Certs and PrivateKey which also performs auto-refresh when stream changes in a given provider.It will be also address: #5241