-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: topic with one partition cannot be updated #6560
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerrypeng
requested review from
sijie,
codelipenghui,
merlimat,
srkukarni and
jiazhai
and removed request for
sijie and
codelipenghui
March 19, 2020 06:11
jerrypeng
force-pushed
the
fix_scaling_one_partition
branch
from
March 19, 2020 06:14
27a626a
to
4b8aeac
Compare
aahmed-se
approved these changes
Mar 19, 2020
codelipenghui
approved these changes
Mar 19, 2020
/pulsarbot run-failure-checks |
codelipenghui
added
type/bug
The PR fixed a bug or issue reported a bug
release/2.5.1
labels
Mar 19, 2020
merlimat
reviewed
Mar 19, 2020
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java
Show resolved
Hide resolved
merlimat
approved these changes
Mar 19, 2020
tuteng
pushed a commit
to AmateurEvents/pulsar
that referenced
this pull request
Mar 21, 2020
* Fix: topic with one partition cannot be updated (cherry picked from commit 9602c9b)
tuteng
pushed a commit
that referenced
this pull request
Apr 6, 2020
* Fix: topic with one partition cannot be updated (cherry picked from commit 9602c9b)
tuteng
pushed a commit
that referenced
this pull request
Apr 13, 2020
* Fix: topic with one partition cannot be updated (cherry picked from commit 9602c9b)
jiazhai
pushed a commit
to jiazhai/pulsar
that referenced
this pull request
May 18, 2020
* Fix: topic with one partition cannot be updated (cherry picked from commit 9602c9b)
huangdx0726
pushed a commit
to huangdx0726/pulsar
that referenced
this pull request
Aug 24, 2020
* Fix: topic with one partition cannot be updated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Previously, we add the the following change to allow partitioned topics to be created with one partition:
#4764
However, updating a partitioned topic with one partition to more than one partition does not work and will return the following error:
: javax.ws.rs.ClientErrorException: HTTP 409 Conflict
Topic is not partitioned topic
Reason: Topic is not partitioned topic