[Issue 5903] Support compact all partitions of a partitioned topic
#6537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiazhai
reviewed
Mar 15, 2020
| verify(response, timeout(5000).times(1)).resume(responseCaptor.capture()); | ||
| Assert.assertEquals(responseCaptor.getValue().getStatus(), Response.Status.NO_CONTENT.getStatusCode()); | ||
|
|
||
| // create partitioned topic and compaction on it |
There was a problem hiding this comment.
@murong00 thanks for the contribute, Would you please help add a test that really called into and execute the compact? Seems this is only the top level method call, and not called into the methods, and some of the code in PersistentTopicsBase.java seems not covered.
If there is no ut framework for this, we could add a integration test for it.
There was a problem hiding this comment.
Added a unit test to cover the compact logic and just keep this top level method call test.
|
@jiazhai I hava added a unit test to cover the compact logic, please help to take a look. |
sijie
approved these changes
Mar 18, 2020
|
/pulsarbot run-failure-checks |
sijie
approved these changes
Mar 19, 2020
huangdx0726
pushed a commit
to huangdx0726/pulsar
that referenced
this pull request
Aug 24, 2020
…pache#6537) * Resolve conflict. * Add a unit test to cover the compact logic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes #5903
If there is a partitioned topic with too many partitions, users need to
compactone by one.Modifications
Async method
triggerCompactionand support tocompacton a partitioned topic.