Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hotfix] Remove problematic semicolon from conf #6303

Merged
merged 1 commit into from
Feb 12, 2020

Conversation

klevy-toast
Copy link
Contributor

@klevy-toast klevy-toast commented Feb 12, 2020

Motivation

When trying to run pulsar standalone on my machine I encountered this error.

[AppClassLoader@3b192d32] info AspectJ Weaver Version 1.9.2 built on Wednesday Oct 24, 2018 at 15:43:33 GMT
[AppClassLoader@3b192d32] info register classloader jdk.internal.loader.ClassLoaders$AppClassLoader@3b192d32
[AppClassLoader@3b192d32] info using configuration file:/Users/kailevy/toast/git-repos/pulsar/pulsar-zookeeper/target/pulsar-zookeeper.jar!/META-INF/aop.xml
[AppClassLoader@3b192d32] info using configuration file:/Users/kailevy/toast/git-repos/pulsar/pulsar-zookeeper-utils/target/pulsar-zookeeper-utils.jar!/META-INF/aop.xml
[AppClassLoader@3b192d32] info register aspect org.apache.pulsar.zookeeper.FinalRequestProcessorAspect
[AppClassLoader@3b192d32] info register aspect org.apache.pulsar.zookeeper.ZooKeeperServerAspect
[AppClassLoader@3b192d32] info register aspect org.apache.pulsar.broker.zookeeper.aspectj.ClientCnxnAspect
Warning: Nashorn engine is planned to be removed from a future JDK release
Exception in thread "main" java.lang.IllegalArgumentException: failed to initialize bookkeeperExplicitLacIntervalInMills field while setting value 0;
	at org.apache.pulsar.common.util.FieldParser.lambda$update$0(FieldParser.java:146)
	at java.base/java.util.Spliterators$ArraySpliterator.forEachRemaining(Spliterators.java:948)
	at java.base/java.util.stream.ReferencePipeline$Head.forEach(ReferencePipeline.java:658)
	at org.apache.pulsar.common.util.FieldParser.update(FieldParser.java:135)
	at org.apache.pulsar.common.configuration.PulsarConfigurationLoader.create(PulsarConfigurationLoader.java:97)
	at org.apache.pulsar.common.configuration.PulsarConfigurationLoader.create(PulsarConfigurationLoader.java:74)
	at org.apache.pulsar.PulsarStandaloneStarter.<init>(PulsarStandaloneStarter.java:60)
	at org.apache.pulsar.PulsarStandaloneStarter.main(PulsarStandaloneStarter.java:117)
Caused by: java.lang.RuntimeException: Cannot convert from java.lang.String to java.lang.Integer. Conversion failed with null
	at org.apache.pulsar.common.util.FieldParser.convert(FieldParser.java:119)
	at org.apache.pulsar.common.util.FieldParser.value(FieldParser.java:190)
	at org.apache.pulsar.common.util.FieldParser.lambda$update$0(FieldParser.java:141)
	... 7 more
Caused by: java.lang.reflect.InvocationTargetException
	at jdk.internal.reflect.GeneratedMethodAccessor1.invoke(Unknown Source)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:566)
	at org.apache.pulsar.common.util.FieldParser.convert(FieldParser.java:115)
	... 9 more
Caused by: java.lang.NumberFormatException: For input string: "0;"
	at java.base/java.lang.NumberFormatException.forInputString(NumberFormatException.java:65)
	at java.base/java.lang.Integer.parseInt(Integer.java:652)
	at java.base/java.lang.Integer.valueOf(Integer.java:983)
	at org.apache.pulsar.common.util.FieldParser.stringToInteger(FieldParser.java:262)
	... 13 more

Looks to be a typo introduced in the config recently.

Modifications

This change simply removes the offending semicolon from the default configs.

Copy link
Contributor

@codelipenghui codelipenghui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix.

@codelipenghui codelipenghui added the type/bug The PR fixed a bug or issue reported a bug label Feb 12, 2020
@codelipenghui codelipenghui added this to the 2.6.0 milestone Feb 12, 2020
@codelipenghui
Copy link
Contributor

The bug is introduced by #5822. So we don't need to release at 2.5.1

@merlimat merlimat merged commit 50d3599 into apache:master Feb 12, 2020
@tuteng
Copy link
Member

tuteng commented Feb 23, 2020

Add label release/2.5.1, ping @codelipenghui

due Error:

[AppClassLoader@18b4aac2] info register aspect org.apache.pulsar.zookeeper.ZooKeeperServerAspect
Exception in thread "main" java.lang.IllegalArgumentException: failed to initialize bookkeeperExplicitLacIntervalInMills field while setting value 0;
	at org.apache.pulsar.common.util.FieldParser.lambda$update$0(FieldParser.java:146)
	at java.util.Spliterators$ArraySpliterator.forEachRemaining(Spliterators.java:948)
	at java.util.stream.ReferencePipeline$Head.forEach(ReferencePipeline.java:580)
	at org.apache.pulsar.common.util.FieldParser.update(FieldParser.java:135)
	at org.apache.pulsar.common.configuration.PulsarConfigurationLoader.create(PulsarConfigurationLoader.java:97)
	at org.apache.pulsar.common.configuration.PulsarConfigurationLoader.create(PulsarConfigurationLoader.java:74)
	at org.apache.pulsar.PulsarStandaloneStarter.<init>(PulsarStandaloneStarter.java:60)
	at org.apache.pulsar.PulsarStandaloneStarter.main(PulsarStandaloneStarter.java:117)
Caused by: java.lang.RuntimeException: Cannot convert from java.lang.String to java.lang.Integer. Conversion failed with null
	at org.apache.pulsar.common.util.FieldParser.convert(FieldParser.java:119)
	at org.apache.pulsar.common.util.FieldParser.value(FieldParser.java:190)
	at org.apache.pulsar.common.util.FieldParser.lambda$update$0(FieldParser.java:141)
	... 7 more
Caused by: java.lang.reflect.InvocationTargetException
	at sun.reflect.GeneratedMethodAccessor2.invoke(Unknown Source)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.apache.pulsar.common.util.FieldParser.convert(FieldParser.java:115)
	... 9 more
Caused by: java.lang.NumberFormatException: For input string: "0;"
	at java.lang.NumberFormatException.forInputString(NumberFormatException.java:65)
	at java.lang.Integer.parseInt(Integer.java:580)
	at java.lang.Integer.valueOf(Integer.java:766)
	at org.apache.pulsar.common.util.FieldParser.stringToInteger(FieldParser.java:262)
	... 13 more

tuteng pushed a commit to AmateurEvents/pulsar that referenced this pull request Feb 23, 2020
tuteng pushed a commit to AmateurEvents/pulsar that referenced this pull request Mar 21, 2020
tuteng pushed a commit that referenced this pull request Apr 6, 2020
tuteng pushed a commit that referenced this pull request Apr 13, 2020
jiazhai pushed a commit to jiazhai/pulsar that referenced this pull request May 18, 2020
huangdx0726 pushed a commit to huangdx0726/pulsar that referenced this pull request Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release/2.5.1 type/bug The PR fixed a bug or issue reported a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants