[function_worker] Fix deploy of WindowFunctions #6246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sijie
reviewed
Feb 6, 2020
There was a problem hiding this comment.
interesting. it seems that we don't have an integration test to cover window function. does it? @jerrypeng
sijie
approved these changes
Feb 12, 2020
|
/pulsarbot run-failure-checks |
1 similar comment
|
/pulsarbot run-failure-checks |
tuteng
pushed a commit
to AmateurEvents/pulsar
that referenced
this pull request
Feb 23, 2020
### Motivation In pulsar 2.5.0 deploying window functions fails because its class doesn't pass validation. The behavior looks the same in current master. ### Modifications Add `WindowFunction.class` to the list of allowed function classes
tuteng
pushed a commit
to AmateurEvents/pulsar
that referenced
this pull request
Mar 21, 2020
### Motivation In pulsar 2.5.0 deploying window functions fails because its class doesn't pass validation. The behavior looks the same in current master. ### Modifications Add `WindowFunction.class` to the list of allowed function classes (cherry picked from commit 47b944b)
tuteng
pushed a commit
that referenced
this pull request
Apr 13, 2020
### Motivation In pulsar 2.5.0 deploying window functions fails because its class doesn't pass validation. The behavior looks the same in current master. ### Modifications Add `WindowFunction.class` to the list of allowed function classes (cherry picked from commit 47b944b)
jiazhai
pushed a commit
to jiazhai/pulsar
that referenced
this pull request
May 18, 2020
### Motivation In pulsar 2.5.0 deploying window functions fails because its class doesn't pass validation. The behavior looks the same in current master. ### Modifications Add `WindowFunction.class` to the list of allowed function classes (cherry picked from commit 47b944b)
huangdx0726
pushed a commit
to huangdx0726/pulsar
that referenced
this pull request
Aug 24, 2020
### Motivation In pulsar 2.5.0 deploying window functions fails because its class doesn't pass validation. The behavior looks the same in current master. ### Modifications Add `WindowFunction.class` to the list of allowed function classes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This causes
WindowFunctions not to be deployable from pulsar-admin.Motivation
In pulsar 2.5.0 deploying window functions fails because its class doesn't pass validation.
The behavior looks the same in current master.
Modifications
Add
WindowFunction.classto the list of allowed function classesVerifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation