[Issues 5709]remove the namespace checking #5716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tuteng
reviewed
Nov 21, 2019
There was a problem hiding this comment.
Update comment https://github.com/apache/pulsar/pull/5716/files#diff-e513da2014c39f6b12d8b1232af8ff2bL183
I think you can try to add a unit test for topicNameValid.
sijie
requested changes
Nov 21, 2019
|
I have added it. |
jiazhai
reviewed
Nov 23, 2019
pulsar-client/src/test/java/org/apache/pulsar/client/impl/MultiTopicsConsumerImplTest.java
Outdated
Show resolved
Hide resolved
jiazhai
reviewed
Nov 23, 2019
pulsar-client/src/test/java/org/apache/pulsar/client/impl/MultiTopicsConsumerImplTest.java
Outdated
Show resolved
Hide resolved
sijie
requested changes
Nov 24, 2019
| conf.setStatsIntervalSeconds(100); | ||
|
|
||
| ThreadFactory threadFactory = new DefaultThreadFactory("client-test-multi", Thread.currentThread().isDaemon()); | ||
| EventLoopGroup eventLoopGroup = EventLoopUtil.newEventLoopGroup(conf.getNumIoThreads(), threadFactory); |
There was a problem hiding this comment.
out of curiosity, why do you create an external event loop?
If you are using an external event loop, it is a good practice to shutdown the event loop at the end of the test.
|
|
||
| ThreadFactory threadFactory = new DefaultThreadFactory("client-test-multi", Thread.currentThread().isDaemon()); | ||
| EventLoopGroup eventLoopGroup = EventLoopUtil.newEventLoopGroup(conf.getNumIoThreads(), threadFactory); | ||
| ExecutorService listenerExecutor = Executors.newSingleThreadScheduledExecutor(threadFactory); |
| .create(); | ||
| producer.send("default/MultiTopics1-Message1"); | ||
| producer1.send("test-multi/MultiTopics2-Message1"); | ||
| producer.closeAsync(); |
There was a problem hiding this comment.
you need add the logic to verify you receive the messages that are produced by producer and producer1
sijie
requested changes
Nov 26, 2019
| public void received(Consumer<byte[]> consumer, Message<byte[]> msg) { | ||
| if("producer".equals(msg.getProducerName()) || "producer1".equals(msg.getProducerName())){ | ||
| String message = new String(msg.getData()); | ||
| assertTrue(message.contains("MultiTopics")); |
There was a problem hiding this comment.
The assertion is done in another thread. The code might never run since you close consumer immediately after producers sent the records.
Please change the logic to use #receive. Add the logic to receive messages and verify them after line 109.
| public void received(Consumer<byte[]> consumer, Message<byte[]> msg) { | ||
| if("producer".equals(msg.getProducerName()) || "producer1".equals(msg.getProducerName())){ | ||
| String message = new String(msg.getData()); | ||
| assertTrue(message.contains("MultiTopics")); |
There was a problem hiding this comment.
The assertion is done in another thread. The code might never run since you close consumer immediately after producers sent the records.
Please change the logic to use #receive. Add the logic to receive messages and verify them after line 109.
There was a problem hiding this comment.
I'v fixed ,PTAL.
|
retest this please |
|
run java8 tests |
|
run java8 tests |
|
Please check unit test use command @huangdx0726 : |
codelipenghui
requested changes
Dec 7, 2019
| } else { | ||
| return false; | ||
| } | ||
| return false; |
There was a problem hiding this comment.
Can simplify by
topic -> !TopicName.isValid(topic)
There was a problem hiding this comment.
I'v fixed ,PTAL.
Comment on lines
85
to
87
| Consumer consumer = clientImpl.newConsumer().topic("persistent://public/test-multi/MultiTopics2") | ||
| .subscriptionName("multiTopicSubscription") | ||
| .subscribe(); |
There was a problem hiding this comment.
I think you need to create a consumer which subscribe multi topics in multi namespaces right? Or can you clarify how the new test cover your change in this PR.
|
@tuteng The unit test is passed in local ,PTAL. |
|
run java8 tests |
|
@huangdx0726 to take a look |
jiazhai
reviewed
Dec 9, 2019
| public void multiTopicsInDifferentNameSpace() throws PulsarClientException { | ||
| List<String> topics = new ArrayList<>(); | ||
| topics.add("persistent://public/default/MultiTopics1"); | ||
| topics.add("persistent://public/test-multi/MultiTopics2"); |
There was a problem hiding this comment.
Seems you need create namespace "test-multi" first?
pulsar Service not started？ |
jiazhai
reviewed
Dec 17, 2019
| topics.add("persistent://public/test-multi/MultiTopics2"); | ||
| topics.add("persistent://public/test-multi/MultiTopics3"); | ||
| ClientConfigurationData conf = new ClientConfigurationData(); | ||
| conf.setServiceUrl("pulsar://localhost:6650"); |
There was a problem hiding this comment.
@huangdx0726 Seems this is related to your error. since this test MultiTopicsConsumerImplTest not start pulsar service at all.
Please move this testcast into TopicsConsumerImplTest, which contains all needed setups.
There was a problem hiding this comment.
I have fixed as persd your comment, PTAL.
|
@jiazhai can you review this pull request again? |
ut not passed |
|
May i create tenant ‘public’ in this test unint？ |
|
@jiazhai I'v fixed ,PTAL. |
|
/pulsarbot run-failure-checks |
1 similar comment
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
3 similar comments
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
codelipenghui
approved these changes
Jun 2, 2020
|
/pulsarbot run-failure-checks |
1 similar comment
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
zeo1995
pushed a commit
to zeo1995/pulsar
that referenced
this pull request
Jun 5, 2020
…te-update * 'website-update' of github.com:zeo1995/pulsar: (432 commits) Fixed ordering issue in KeyShared dispatcher when adding consumer (apache#7106) Fix Duplicated messages are sent to dead letter topic apache#6960 (apache#7021) [Issue 2793][Doc]--Update the TLS hostname verification for CPP and Python clients (apache#7162) [Doc]--set netty mex frame size (apache#7174) [Doc] Update for the maximum message size (apache#7171) Fixed KeyShared consumers getting stuck on delivery (apache#7105) [apache#6003][pulsar-functions] Possibility to add builtin Functions (apache#6895) [Issue 6921][pulsar-broker-common] Replaced "Paths.get(...).getParent()", because it's system dependent and uses '\' as path separator on Windows (apache#6992) Improve broker unit test CI (apache#7173) Fix typo in exception message (apache#7027) Support KeyValue Schema Use Null Key And Null Value (apache#7139) [Doc]--Update documents for support consumer priority level in failover mode (apache#7136) Add schema config to cpp and cgo docs. (apache#7137) [Doc]--Update for the maximum message size (apache#7160) [C++] Expose ZSTD and Snappy compression to C API (apache#7014) [pulsar-proxy] add proxyLogLevel into config file (apache#6948) Add multi-hosts example for bookkeeperMetadataServiceUri (apache#6998) support for termination of partitioned topic (apache#6126) Use pure-java Air-Compressor instead of JNI based libraries (apache#5390) [Issues 5709]remove the namespace checking (apache#5716) ... # Conflicts: # site2/website/scripts/split-swagger-by-version.js
huangdx0726
added a commit
to huangdx0726/pulsar
that referenced
this pull request
Aug 24, 2020
[Issues 5709] remove the namespace checking Support multiple topic subscriptions across multiple namespace Fixes apache#5709 ### Motivation Support multiple topic subscriptions across multiple namespace ### Modifications remove the namespace checking
1 task
sijie
pushed a commit
that referenced
this pull request
Feb 8, 2021
Fixes #9449 ### Motivation This is a catchup work for #5716 that supports multiple topic subscriptions across multiple namespaces. ### Modifications - Move the check for namespace in `MultiTopicsConsumerImpl` to `PatternMultiTopicsConsumerImpl` that uses a regex subscription. - Fix the existed tests for subscription on topics across different namespaces. ### Verifying this change This change is already covered by existing tests, such as *BasicEndToEndTest.testMultiTopicsConsumerDifferentNamespace*.
codelipenghui
pushed a commit
that referenced
this pull request
Feb 8, 2021
Fixes #9449 ### Motivation This is a catchup work for #5716 that supports multiple topic subscriptions across multiple namespaces. ### Modifications - Move the check for namespace in `MultiTopicsConsumerImpl` to `PatternMultiTopicsConsumerImpl` that uses a regex subscription. - Fix the existed tests for subscription on topics across different namespaces. ### Verifying this change This change is already covered by existing tests, such as *BasicEndToEndTest.testMultiTopicsConsumerDifferentNamespace*. (cherry picked from commit 69e9322)
codelipenghui
pushed a commit
to streamnative/pulsar-archived
that referenced
this pull request
Feb 8, 2021
Fixes apache#9449 ### Motivation This is a catchup work for apache#5716 that supports multiple topic subscriptions across multiple namespaces. ### Modifications - Move the check for namespace in `MultiTopicsConsumerImpl` to `PatternMultiTopicsConsumerImpl` that uses a regex subscription. - Fix the existed tests for subscription on topics across different namespaces. ### Verifying this change This change is already covered by existing tests, such as *BasicEndToEndTest.testMultiTopicsConsumerDifferentNamespace*. (cherry picked from commit 69e9322) (cherry picked from commit 3031550)
codelipenghui
pushed a commit
that referenced
this pull request
Feb 18, 2021
Fixes #9449 ### Motivation This is a catchup work for #5716 that supports multiple topic subscriptions across multiple namespaces. ### Modifications - Move the check for namespace in `MultiTopicsConsumerImpl` to `PatternMultiTopicsConsumerImpl` that uses a regex subscription. - Fix the existed tests for subscription on topics across different namespaces. ### Verifying this change This change is already covered by existing tests, such as *BasicEndToEndTest.testMultiTopicsConsumerDifferentNamespace*. (cherry picked from commit 69e9322)
merlimat
pushed a commit
to apache/pulsar-client-python
that referenced
this pull request
Sep 29, 2022
Fixes #9449 ### Motivation This is a catchup work for apache/pulsar#5716 that supports multiple topic subscriptions across multiple namespaces. ### Modifications - Move the check for namespace in `MultiTopicsConsumerImpl` to `PatternMultiTopicsConsumerImpl` that uses a regex subscription. - Fix the existed tests for subscription on topics across different namespaces. ### Verifying this change This change is already covered by existing tests, such as *BasicEndToEndTest.testMultiTopicsConsumerDifferentNamespace*.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Issues 5709] remove the namespace checking Support multiple topic subscriptions across multiple namespace
Fixes #5709
Motivation
Support multiple topic subscriptions across multiple namespace
Modifications
remove the namespace checking