Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure client create consumer/producer for 1 partitioned topic #4883

Merged
merged 1 commit into from
Aug 6, 2019

Conversation

jiazhai
Copy link
Member

@jiazhai jiazhai commented Aug 4, 2019

Motivation

In PR #4764, we allow to create partitioned topic with 1 partition, But in Pulsar Client, user still not able to do it.
This fix try to make sure user could create consumer/producer for 1 partitioned topic .

Modifications

  • old and new added unit test passed.

@jiazhai jiazhai added this to the 2.4.1 milestone Aug 4, 2019
@jiazhai jiazhai requested review from merlimat and sijie August 4, 2019 06:54
@jiazhai jiazhai self-assigned this Aug 4, 2019
@jiazhai jiazhai requested a review from rdhabalia August 4, 2019 07:27
@jiazhai jiazhai changed the title Make sure produce/consume with 1 partitioned topic Make sure client create consumer/producer for 1 partitioned topic Aug 4, 2019
@sijie
Copy link
Member

sijie commented Aug 5, 2019

// [ERROR] org.apache.maven.surefire.booter.SurefireBooterForkException: ExecutionException The forked VM terminated without properly saying goodbye. VM crash or System.exit called?

run java8 tests

@sijie
Copy link
Member

sijie commented Aug 5, 2019

// PulsarFunctionE2ESecurityTest.testAuthorizationWithAnonymousUser (Created #4889 for tracking a fix for it)

run java8 tests

@jiazhai jiazhai merged commit 128287e into apache:master Aug 6, 2019
jiazhai added a commit that referenced this pull request Aug 26, 2019
### Motivation

IN PR #4883, we support 1 partitioned topic producer/consumer in java client. this is for Cpp client support.

### Modifications
- change cpp client 
- add unit test

### Verifying this change
New added Ut Passed
jiazhai added a commit that referenced this pull request Aug 28, 2019
Motivation
In PR #4764, we allow to create partitioned topic with 1 partition, But in Pulsar Client, user still not able to do it.
This fix try to make sure user could create consumer/producer for 1 partitioned topic .

Modifications
- old and new added unit test passed.
(cherry picked from commit 128287e)
jiazhai added a commit that referenced this pull request Aug 28, 2019
### Motivation

IN PR #4883, we support 1 partitioned topic producer/consumer in java client. this is for Cpp client support.

### Modifications
- change cpp client
- add unit test

### Verifying this change
New added Ut Passed

(cherry picked from commit bf94890)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants