Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve][broker] Refactor a private method to eliminate an unnecessary parameter #23915

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

guan46
Copy link
Contributor

@guan46 guan46 commented Jan 31, 2025

Motivation

  • The canDispatchEntry method uses MutableBoolean as an argument, and then changes its value internally, but this variable is not necessary

Modifications

  • Optimize code for readability

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository: guan46#3

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Jan 31, 2025
@guan46
Copy link
Contributor Author

guan46 commented Jan 31, 2025

I accidentally closed #23904, I submitted a new pr @lhotari

@lhotari
Copy link
Member

lhotari commented Jan 31, 2025

I accidentally closed #23904, I submitted a new pr @lhotari

@guan46 If you accidentially close a PR, it can be reopened. It's better to continue on the original PR. I'll close this one and reopen the original one.

@lhotari lhotari closed this Jan 31, 2025
@lhotari
Copy link
Member

lhotari commented Jan 31, 2025

Oh, I see why #23904 was closed. It used your master branch. When creating pull requests, it's necessary to aways create a branch so that you don't run into the issue. I'll reopen this one and let's continue on this PR.

@lhotari lhotari reopened this Jan 31, 2025
@lhotari
Copy link
Member

lhotari commented Jan 31, 2025

Oh, I see why #23904 was closed. It used your master branch. When creating pull requests, it's necessary to aways create a branch so that you don't run into the issue. I'll reopen this one and let's continue on this PR.

I updated https://pulsar.apache.org/contribute/personal-ci/ instructions with relevant information.

Copy link
Member

@lhotari lhotari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address #23904 (comment) and run tests with Personal CI in your own fork.

@guan46
Copy link
Contributor Author

guan46 commented Feb 1, 2025

I updated the address, but there are some errors in the tests.Please take a look. @lhotari

@lhotari
Copy link
Member

lhotari commented Feb 3, 2025

I updated the address, but there are some errors in the tests.Please take a look. @lhotari

What you should do is to ensure that tests pass with your changes. If not, it's either a flaky test or your changes break the tests.
For example this test breaks: https://github.com/guan46/pulsar/actions/runs/13072194671/job/36541465274?pr=3#step:11:2705 .

If you think that a test failure could be a flaky test, you can "re-run failed jobs" in the GitHub Actions UI.

For actual test failures caused by your changes, you should run them in IDE and debug the reasons why they fail with your changes. It would be pointless if a contributor makes PRs without handling this step on their own.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-not-needed Your PR changes do not impact docs release/4.0.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants