-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improve][broker] Refactor a private method to eliminate an unnecessary parameter #23915
base: master
Are you sure you want to change the base?
Conversation
Oh, I see why #23904 was closed. It used your master branch. When creating pull requests, it's necessary to aways create a branch so that you don't run into the issue. I'll reopen this one and let's continue on this PR. |
I updated https://pulsar.apache.org/contribute/personal-ci/ instructions with relevant information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please address #23904 (comment) and run tests with Personal CI in your own fork.
I updated the address, but there are some errors in the tests.Please take a look. @lhotari |
What you should do is to ensure that tests pass with your changes. If not, it's either a flaky test or your changes break the tests. If you think that a test failure could be a flaky test, you can "re-run failed jobs" in the GitHub Actions UI. For actual test failures caused by your changes, you should run them in IDE and debug the reasons why they fail with your changes. It would be pointless if a contributor makes PRs without handling this step on their own. |
Motivation
Modifications
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: guan46#3