Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][test] Add reconsumeLater call in RetryTopicTest#testRetryTopicWithMultiTopic. #23857

Merged

Conversation

thetumbled
Copy link
Member

@thetumbled thetumbled commented Jan 17, 2025

Motivation

org.apache.pulsar.client.api.RetryTopicTest#testRetryTopicWithMultiTopic don't test the behavior of retry topic at all.
Instead of calling reconsumeLater to trigger redelivery, current test code trigger redelivery base on ack timeout.

Modifications

Add reconsumeLater call to test the behavior of retry topic with multiple topics.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@thetumbled thetumbled self-assigned this Jan 17, 2025
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Jan 17, 2025
@thetumbled thetumbled added area/test and removed doc-not-needed Your PR changes do not impact docs labels Jan 17, 2025
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Jan 17, 2025
@thetumbled thetumbled changed the title [fix] [broker] Add reconsumeLater call. [fix] [test] Add reconsumeLater call. Jan 17, 2025
@thetumbled thetumbled changed the title [fix] [test] Add reconsumeLater call. [fix] [test] Add reconsumeLater call in RetryTopicTest#testRetryTopicWithMultiTopic. Jan 17, 2025
Copy link
Member

@nodece nodece left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

BTW, DO NOT add the blank between [type] and [scope].

@thetumbled thetumbled changed the title [fix] [test] Add reconsumeLater call in RetryTopicTest#testRetryTopicWithMultiTopic. [fix][test] Add reconsumeLater call in RetryTopicTest#testRetryTopicWithMultiTopic. Jan 17, 2025
@thetumbled thetumbled merged commit 8015795 into apache:master Jan 17, 2025
65 of 72 checks passed
lhotari pushed a commit that referenced this pull request Jan 17, 2025
lhotari pushed a commit that referenced this pull request Jan 17, 2025
lhotari pushed a commit that referenced this pull request Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants