[fix][doc] Refine ClientBuilder#memoryLimit and ConsumerBuilder#autoScaledReceiverQueueSizeEnabled javadoc #23687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erQueueSizeEnabled javadoc
dao-jun
approved these changes
Dec 13, 2024
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Dec 19, 2024
…caledReceiverQueueSizeEnabled javadoc (apache#23687) (cherry picked from commit 0845c21) (cherry picked from commit 0d757ad)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Dec 23, 2024
…caledReceiverQueueSizeEnabled javadoc (apache#23687) (cherry picked from commit 0845c21) (cherry picked from commit 0d757ad)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The
ClientBuilder#memoryLimitwas introduced in PIP-74 and originally affected producers only. In #15216, the memory limit was updated to include consumer memory usage whenConsumerBuilder#autoScaledReceiverQueueSizeEnabledis enabled. This patch updates the Javadoc to reflect the actual behavior.Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: