[fix][broker] Catch exception for entry payload interceptor processor #23683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodece
approved these changes
Dec 5, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #23683 +/- ##
============================================
+ Coverage 73.57% 74.45% +0.88%
- Complexity 32624 35102 +2478
============================================
Files 1877 1945 +68
Lines 139502 147454 +7952
Branches 15299 16270 +971
============================================
+ Hits 102638 109792 +7154
- Misses 28908 29200 +292
- Partials 7956 8462 +506
Flags with carried forward coverage won't be shown. Click here to find out more.
|
lhotari
reviewed
Dec 5, 2024
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/OpAddEntry.java
Show resolved
Hide resolved
dao-jun
approved these changes
Dec 6, 2024
lhotari
approved these changes
Dec 6, 2024
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Dec 12, 2024
…apache#23683) (cherry picked from commit 24c337f) (cherry picked from commit 8a47295)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Dec 12, 2024
…apache#23683) (cherry picked from commit 24c337f) (cherry picked from commit 8a47295)
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, the entry payload interceptor processor doesn't catch exceptions, the exception will be swallowed by the executor task.
Modifications
Catch exception for entry payload interceptor processor.
Verifying this change
Add a test for catching exceptions from the payload input interceptor processor.
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-complete