Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][broker] Invoke custom BrokerInterceptor's onFilter method if it's defined #23676

Merged

Conversation

jiangpengcheng
Copy link
Contributor

Fixes #23670

Main Issue: #xyz

PIP: #xyz

Motivation

The BrokerInterceptor interface has a onFilter method, but it is never invoked

Modifications

Verifying this change

  • Make sure that the change passes the CI checks.

  • This change is already covered by existing tests, such as (please describe tests).

    • TestBrokerInterceptors.java#test

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository: jiangpengcheng#36

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Dec 3, 2024
@mattisonchao mattisonchao reopened this Dec 3, 2024
@jiangpengcheng
Copy link
Contributor Author

/pulsarbot rerun-failure-checks

@codecov-commenter
Copy link

codecov-commenter commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.44%. Comparing base (bbc6224) to head (1ff6d0e).
Report is 775 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #23676      +/-   ##
============================================
+ Coverage     73.57%   74.44%   +0.87%     
- Complexity    32624    35063    +2439     
============================================
  Files          1877     1944      +67     
  Lines        139502   147341    +7839     
  Branches      15299    16260     +961     
============================================
+ Hits         102638   109694    +7056     
- Misses        28908    29201     +293     
- Partials       7956     8446     +490     
Flag Coverage Δ
inttests 27.42% <0.00%> (+2.84%) ⬆️
systests 24.41% <0.00%> (+0.09%) ⬆️
unittests 73.82% <100.00%> (+0.97%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...er/intercept/BrokerInterceptorWithClassLoader.java 88.07% <100.00%> (-0.99%) ⬇️
.../java/org/apache/pulsar/broker/web/WebService.java 90.80% <100.00%> (-3.35%) ⬇️

... and 665 files with indirect coverage changes

@mattisonchao mattisonchao merged commit 7f7e12b into apache:master Dec 4, 2024
110 of 112 checks passed
mattisonchao pushed a commit that referenced this pull request Dec 4, 2024
mattisonchao pushed a commit that referenced this pull request Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] onFilter method in custom BrokerInterceptor doesn't get called
3 participants