[fix][client] Fix race-condition causing doReconsumeLater to hang when creating retryLetterProducer has failed #23560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…reate retryLetterProducer is failed.
|
Do you have a chance to add a test case? |
I've added a test case. |
lhotari
added
release/3.3.3
release/3.0.8
release/4.0.1
type/bug
lhotari
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #23560 +/- ##
============================================
+ Coverage 73.57% 74.04% +0.47%
- Complexity 32624 34650 +2026
============================================
Files 1877 1945 +68
Lines 139502 151644 +12142
Branches 15299 17232 +1933
============================================
+ Hits 102638 112289 +9651
- Misses 28908 30618 +1710
- Partials 7956 8737 +781
Flags with carried forward coverage won't be shown. Click here to find out more.
|
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Dec 6, 2024
…n creating retryLetterProducer has failed (apache#23560) (cherry picked from commit bf1f677) (cherry picked from commit 5f25367)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Dec 9, 2024
…n creating retryLetterProducer has failed (apache#23560) (cherry picked from commit bf1f677) (cherry picked from commit 5f25367)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When
retryLetterProducercreation fails,retryLetterProducerwill be set to null. SoretryLetterProducer==nullmay occur when race-condition is present, at this time, the results cannot be completed.Only handle the situation when retryLetterProducer is not equal to null:
pulsar/pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java
Line 678 in 3f12269
Modifications
When
retryLetterProducer==null, mark the result as an completeExceptionally.Documentation
docdoc-requireddoc-not-neededdoc-complete