[fix][ml] Managed ledger should recover after open ledger failed #23368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Demogorgon314
added
type/bug
Demogorgon314
requested review from
merlimat,
lhotari,
hangc0276,
eolivelli,
codelipenghui,
BewareMyPower,
zymap and
poorbarcode
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #23368 +/- ##
============================================
+ Coverage 73.57% 74.59% +1.02%
- Complexity 32624 34485 +1861
============================================
Files 1877 1934 +57
Lines 139502 145132 +5630
Branches 15299 15870 +571
============================================
+ Hits 102638 108267 +5629
+ Misses 28908 28572 -336
- Partials 7956 8293 +337
Flags with carried forward coverage won't be shown. Click here to find out more.
|
BewareMyPower
approved these changes
Sep 29, 2024
BewareMyPower
approved these changes
Sep 29, 2024
lhotari
pushed a commit
that referenced
this pull request
Oct 10, 2024
) (cherry picked from commit 77cb67a)
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Oct 15, 2024
…che#23368) (cherry picked from commit 77cb67a) (cherry picked from commit c80eb40) (cherry picked from commit 7daad7a)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Oct 16, 2024
…che#23368) (cherry picked from commit 77cb67a) (cherry picked from commit c80eb40) (cherry picked from commit 7daad7a)
Open
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When open managed ledger fails, the
entryCacheManager's ml cache will be a closed managed ledger, then if we open this ledger again, it will fail to read becauseorg.apache.bookkeeper.mledger.ManagedLedgerException: LastConfirmedEntry is null when reading ledger xxxexception.Modifications
entryCacheManager's cache if open ml fails.Documentation
docdoc-requireddoc-not-neededdoc-complete