-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improve][pip] PIP-380: Support setting up specific namespaces to skipping the load-shedding #23304
Conversation
It seems fine. Just thinking that there could be similar requirements for user defined namespaces and therefore having a property in the namespace policy to control this would be useful. Instead of a single binary value, perhaps it could be some type of value that would be used for ordering the namespace bundles that are picked as candidates for load shedding. |
I wonder if we can limit this blacklisting to the TransferShedder under |
@heesung-sn I would like to use the |
I think we probably want to explore namespace policy like this work. |
Adding a namespace policy is a good idea, let me update the PIP. |
@lhotari Are you suggesting adding a |
ping @lhotari |
PIP-379 is already taken, I increased the number to PIP-380. The way to find the next available number is to check the dev mailing list and open PRs. The first one to open a discussion for a specific PIP number takes it. This is the PIP-379 discussion: https://lists.apache.org/thread/l5zjq0fb2dscys3rsn6kfl7505tbndlx . I somehow missed your PR when I made the PIP number assignment. I'm sorry about that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@Demogorgon314 It was something to consider for the future. |
@Demogorgon314 Please update the links to the PIP discussion and voting threads. |
No description provided.