[fix][client] Create the retry producer async #23157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The consumer implementation is creating the retry producer synchronously, potentially unexpectedly blocking the calling thread. This changes modifies this behaviour to fit with how the dead letter queue producer is created—i.e. using the async APIs offloaded to the internal pinned executor.
|
I'm unable to replicate the failed test locally. |
Unfortunately we have a lot of flaky tests. There's a solution called "pulsarbot" which can rerun the failed GitHub Action builds when you add a comment "/pulsarbot rerun-failure-checks" to the PR. I'll perform that now. |
|
/pulsarbot rerun-failure-checks |
lhotari
reviewed
Aug 13, 2024
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java
Outdated
Show resolved
Hide resolved
lhotari
reviewed
Aug 13, 2024
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java
Outdated
Show resolved
Hide resolved
lhotari
reviewed
Aug 13, 2024
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java
Show resolved
Hide resolved
lhotari
requested changes
Aug 13, 2024
lhotari
approved these changes
Aug 14, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #23157 +/- ##
============================================
+ Coverage 73.57% 74.56% +0.98%
- Complexity 32624 33637 +1013
============================================
Files 1877 1920 +43
Lines 139502 144434 +4932
Branches 15299 15803 +504
============================================
+ Hits 102638 107693 +5055
+ Misses 28908 28490 -418
- Partials 7956 8251 +295
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Technoboy-
pushed a commit
that referenced
this pull request
Aug 14, 2024
Co-authored-by: Ómar Yasin <[email protected]>
lhotari
pushed a commit
that referenced
this pull request
Aug 14, 2024
Co-authored-by: Ómar Yasin <[email protected]> (cherry picked from commit a025938)
lhotari
pushed a commit
that referenced
this pull request
Aug 15, 2024
Co-authored-by: Ómar Yasin <[email protected]> (cherry picked from commit a025938)
lhotari
pushed a commit
that referenced
this pull request
Aug 15, 2024
Co-authored-by: Ómar Yasin <[email protected]> (cherry picked from commit a025938)
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Aug 16, 2024
Co-authored-by: Ómar Yasin <[email protected]> (cherry picked from commit a025938) (cherry picked from commit 507d402)
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Aug 16, 2024
Co-authored-by: Ómar Yasin <[email protected]> (cherry picked from commit a025938) (cherry picked from commit f2e1920)
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Aug 16, 2024
Co-authored-by: Ómar Yasin <[email protected]> (cherry picked from commit a025938) (cherry picked from commit 507d402)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Aug 20, 2024
Co-authored-by: Ómar Yasin <[email protected]> (cherry picked from commit a025938) (cherry picked from commit 507d402)
grssam
pushed a commit
to grssam/pulsar
that referenced
this pull request
Sep 4, 2024
Co-authored-by: Ómar Yasin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The consumer implementation is creating the retry producer synchronously, potentially unexpectedly blocking the calling thread.
Modifications
This changes modifies this behaviour to fit with how the dead letter queue producer is created—i.e. using the async APIs offloaded to the internal pinned executor.
Verifying this change
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: