[fix][client] Fix orphan consumer when reconnection and closing are concurrency executing #22958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…concurrent executing
lhotari
changed the title
|
/pulsarbot rerun-failure-checks |
crossoverJie
approved these changes
Jun 24, 2024
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jun 27, 2024
…oncurrency executing (apache#22958) (cherry picked from commit 69b2739) (cherry picked from commit ad4cf9d)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jul 1, 2024
…oncurrency executing (apache#22958) (cherry picked from commit 69b2739) (cherry picked from commit ad4cf9d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
timethread: ConsumerImpl.connectionOpenedthread: ConsumerImpl.closeAsync- reconnectiong
-
cnxisnullreadyclosedand skip sendingrequests to remove consumer in broker memory
After the above steps, there is an orphan consumer in the broker memory, which will cause the error
Exclusive consumer is already connectedand other errors.BTW, this issue may cause the compaction task stuck, because the new reader can not be created successfully due to the previous consumer has not been removed.
You can reproduce the issue by the test
testConcurrencyClosein the PR #22959Modifications
Fix the issue.
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: x