[fix][test] Fix TableViewBuilderImplTest NPE and infinite loop #22924
+21
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhotari
added a commit
that referenced
this pull request
Jun 19, 2024
(cherry picked from commit 2dc0d96)
lhotari
added a commit
that referenced
this pull request
Jun 19, 2024
(cherry picked from commit 2dc0d96)
lhotari
added a commit
that referenced
this pull request
Jun 19, 2024
(cherry picked from commit 2dc0d96)
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jun 21, 2024
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jun 24, 2024
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jun 25, 2024
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Running the test TableViewBuilderImplTest results in an NPE and infinite loop.
Modifications
Properly mock readNextAsync by returning an uncompleted CompletableFuture so that it doesn't cause an infinite loop.
Complete the CompletableFuture with AlreadyClosedException in test cleanup to properly close resources.
Documentation
docdoc-requireddoc-not-neededdoc-complete