-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix][io] Upgrade Debezium oracle connector version to 2.5.4.Final #22813
Conversation
@mukesh154 Please add the following content to your PR description and select a checkbox:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #22813 +/- ##
============================================
- Coverage 73.57% 73.17% -0.41%
- Complexity 32624 32960 +336
============================================
Files 1877 1892 +15
Lines 139502 141902 +2400
Branches 15299 15569 +270
============================================
+ Hits 102638 103830 +1192
- Misses 28908 30054 +1146
- Partials 7956 8018 +62
Flags with carried forward coverage won't be shown. Click here to find out more.
|
<dependency> | ||
<groupId>io.debezium</groupId> | ||
<artifactId>debezium-core</artifactId> | ||
<version>${debezium.oracle.version}</version> | ||
</dependency> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it's a great idea to have a separate version of debezium-core when Oracle connector is used. This will cause class version conflicts as we have seen before. Please see #22668 as an example of this.
I think that should be upgrading Debezium in all connectors at the same time to avoid class version conflicts and the confusion caused for maintenance when multiple versions of Debezium are used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Fixes #22626
Motivation
To Upgrade debezium version for oracle to 2.5.4.Final
Modifications
Upgraded debezium version from 1.9.7.Final to 2.5.4.Final just for oracle connector, so that other connectors such as mysql, postgresql, mongodb, mssql doesn't break.
Verifying this change
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
Check the box below or label this PR directly (if you have committer privilege).
Need to update docs?
doc
doc-required
doc-not-needed
doc-complete