-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix][cli] Remove defaultValue of tenant/namespace for CmdFunctions #22764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodece
approved these changes
May 23, 2024
8cb3499
to
ae56543
Compare
Technoboy-
approved these changes
May 23, 2024
nicoloboschi
approved these changes
May 23, 2024
@jiangpengcheng Could you help review it ? |
jiangpengcheng
approved these changes
May 23, 2024
LGTM |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #22764 +/- ##
============================================
- Coverage 73.57% 73.20% -0.38%
- Complexity 32624 32875 +251
============================================
Files 1877 1889 +12
Lines 139502 141443 +1941
Branches 15299 15520 +221
============================================
+ Hits 102638 103541 +903
- Misses 28908 29908 +1000
- Partials 7956 7994 +38
Flags with carried forward coverage won't be shown. Click here to find out more.
|
RobertIndie
approved these changes
May 23, 2024
hanmz
pushed a commit
to hanmz/pulsar
that referenced
this pull request
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cherry-picked/branch-3.3
doc-not-needed
Your PR changes do not impact docs
ready-to-test
release/3.3.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In #22209, we added defaultValue for tenant/namespace on CmdFunctions, this introduced a break change behavior, user can't use tenant/namespace in
function-config-file
due to tenant/namespace options never null.Modifications
Remove defaultValue of tenant/namespace for CmdFunctions
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: