Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][cli] Remove defaultValue of tenant/namespace for CmdFunctions #22764

Merged
merged 1 commit into from
May 23, 2024

Conversation

coderzc
Copy link
Member

@coderzc coderzc commented May 23, 2024

Motivation

In #22209, we added defaultValue for tenant/namespace on CmdFunctions, this introduced a break change behavior, user can't use tenant/namespace in function-config-file due to tenant/namespace options never null.

Modifications

Remove defaultValue of tenant/namespace for CmdFunctions

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label May 23, 2024
@coderzc coderzc requested review from nodece, Technoboy- and jerrypeng and removed request for jerrypeng May 23, 2024 07:03
@coderzc coderzc force-pushed the remove_cmd_function_default branch from 8cb3499 to ae56543 Compare May 23, 2024 07:10
@coderzc coderzc added release/blocker Indicate the PR or issue that should block the release until it gets resolved release/3.3.0 labels May 23, 2024
@Technoboy-
Copy link
Contributor

@jiangpengcheng Could you help review it ?

@jiangpengcheng
Copy link
Contributor

LGTM

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.20%. Comparing base (bbc6224) to head (ae56543).
Report is 299 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #22764      +/-   ##
============================================
- Coverage     73.57%   73.20%   -0.38%     
- Complexity    32624    32875     +251     
============================================
  Files          1877     1889      +12     
  Lines        139502   141443    +1941     
  Branches      15299    15520     +221     
============================================
+ Hits         102638   103541     +903     
- Misses        28908    29908    +1000     
- Partials       7956     7994      +38     
Flag Coverage Δ
inttests 27.43% <ø> (+2.84%) ⬆️
systests 24.69% <ø> (+0.36%) ⬆️
unittests 72.20% <ø> (-0.64%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...java/org/apache/pulsar/admin/cli/CmdFunctions.java 45.96% <ø> (-0.25%) ⬇️

... and 347 files with indirect coverage changes

@nodece nodece merged commit 951eb51 into apache:master May 23, 2024
52 of 53 checks passed
coderzc added a commit that referenced this pull request May 23, 2024
@coderzc coderzc added cherry-picked/branch-3.3 and removed release/blocker Indicate the PR or issue that should block the release until it gets resolved labels May 23, 2024
@lhotari lhotari modified the milestones: 3.3.0, 4.0.0 Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants