-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improve][ci] Add arm64 image build #22755
Conversation
/pulsarbot rerun-failure-checks |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #22755 +/- ##
============================================
- Coverage 73.57% 73.19% -0.39%
- Complexity 32624 32889 +265
============================================
Files 1877 1889 +12
Lines 139502 141443 +1941
Branches 15299 15520 +221
============================================
+ Hits 102638 103526 +888
- Misses 28908 29921 +1013
- Partials 7956 7996 +40
Flags with carried forward coverage won't be shown. Click here to find out more. |
7981ee4
to
6a88d53
Compare
Signed-off-by: Zixuan Liu <[email protected]>
Signed-off-by: Zixuan Liu <[email protected]>
f319c45
to
2d777a5
Compare
btw. arm based runners became public beta a few days ago. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, good work @nodece .
Once Arm runners are available (by the end of the year), we could use this type of syntax to choose the runner in the matrix. pulsar-java-test-image:
name: Build Pulsar java-test-image docker image for ${{ matrix.platform }}
runs-on: ${{ matrix.runs-on }}
timeout-minutes: 60
needs: ['preconditions', 'build-and-license-check']
if: ${{ needs.preconditions.outputs.docs_only != 'true'}}
strategy:
fail-fast: false
matrix:
include:
- platform: linux/amd64
runs-on: ubuntu-22.04
- platform: linux/arm64
runs-on: arm64-ubuntu-22.04 |
Signed-off-by: Zixuan Liu <[email protected]> (cherry picked from commit fb03d15)
Motivation
Verify the arm64 image build.
Modifications
Documentation
doc
doc-required
doc-not-needed
doc-complete