Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve][broker] Disable JFR metric reporting in OpenTelemetry #22669

Merged
merged 30 commits into from
May 8, 2024

Conversation

dragosvictor
Copy link
Contributor

@dragosvictor dragosvictor commented May 7, 2024

Motivation

Metrics related to JFR are not currently supported by Pulsar, let's disable their reporting until this is needed.

Modifications

Trivial disablement of the metrics.

Verifying this change

  • Make sure that the change passes the CI checks.

This change is already covered by existing tests, such as org.apache.pulsar.opentelemetry.OpenTelemetryServiceTest#testJvmRuntimeMetrics.

Does this pull request potentially affect one of the following parts:

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository: dragosvictor#23

dragosvictor and others added 30 commits April 15, 2024 20:42
Co-authored-by: Lari Hotari <[email protected]>
@dragosvictor dragosvictor marked this pull request as ready for review May 7, 2024 18:18
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label May 7, 2024
@codecov-commenter
Copy link

codecov-commenter commented May 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.72%. Comparing base (bbc6224) to head (6b7ed24).
Report is 606 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #22669      +/-   ##
============================================
- Coverage     73.57%   72.72%   -0.86%     
+ Complexity    32624    32344     -280     
============================================
  Files          1877     1887      +10     
  Lines        139502   141060    +1558     
  Branches      15299    15481     +182     
============================================
- Hits         102638   102580      -58     
- Misses        28908    30616    +1708     
+ Partials       7956     7864      -92     
Flag Coverage Δ
inttests 27.42% <ø> (+2.83%) ⬆️
systests 24.62% <ø> (+0.30%) ⬆️
unittests 71.51% <ø> (-1.34%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...che/pulsar/opentelemetry/OpenTelemetryService.java 88.57% <ø> (-3.43%) ⬇️

... and 354 files with indirect coverage changes

@nodece nodece added this to the 3.3.0 milestone May 8, 2024
@nodece nodece merged commit e2feec8 into apache:master May 8, 2024
54 of 55 checks passed
@lhotari
Copy link
Member

lhotari commented May 8, 2024

@dragosvictor I checked the source code of io.opentelemetry.instrumentation.runtimemetrics.java17.RuntimeMetricsBuilder and io.opentelemetry.instrumentation.runtimemetrics.java17.JfrFeature . It seems that some features are enabled by default.
Documented at https://github.com/open-telemetry/opentelemetry-java-instrumentation/tree/main/instrumentation/runtime-telemetry/runtime-telemetry-java17/library .
I guess we should only enable the metrics at this point that are needed. For example, the network metrics are enabled by default and are most likely useless since I don't think JFR metrics cover Netty.

@dragosvictor dragosvictor deleted the dmisca-pip-264-disable-jfr branch May 14, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-not-needed Your PR changes do not impact docs ready-to-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants