[improve][build] Use slf4j-bom to align slf4j versions #22646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhotari
added
area/build
area/dependency
4 tasks
nodece
approved these changes
May 3, 2024
tisonkun
approved these changes
May 3, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #22646 +/- ##
============================================
- Coverage 73.57% 72.70% -0.88%
+ Complexity 32624 32554 -70
============================================
Files 1877 1887 +10
Lines 139502 141006 +1504
Branches 15299 15478 +179
============================================
- Hits 102638 102516 -122
- Misses 28908 30618 +1710
+ Partials 7956 7872 -84
Flags with carried forward coverage won't be shown. Click here to find out more. |
hanmz
pushed a commit
to hanmz/pulsar
that referenced
this pull request
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
slf4j 2.0.x comes with slf4j-bom which can be used to align slf4j library versions.
Modifications
use slf4j-bom to align slf4j versions
Documentation
docdoc-requireddoc-not-neededdoc-complete