-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix][sec] Upgrade Debezium oracle connector version to avoid CVE-2023-4586 #22641
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Just wondering that we are upgrading this connector to a newer Debezium version than the others. It seems like a hack. I wonder why we are sticking to an old Debezium version for others. |
@lhotari We could update the debezium version for others as well. Since only debezuim-oracle-connector had vulnerabilites (indirectly due to infinispan-client-hotrod) , i updated for oracle. I haven't checked for the other debezium connectors if there are any transitive dependencies which have vulnerabilities. |
…VE-2023-4586 (apache#22641)" This reverts commit 4a59536.
@nikhil-ctds Did you ensure that tests pass? I don't see the tests passing and this PR will need to be reverted. @nicoloboschi @shoothzj Please review the revert PR #22668 |
@nikhilerigila09 In this case, it's the test that validates changes in this area. It was failing consistently. This PR has been reverted in #22668, so there's a new chance to attempt to address CVE-2023-4586 in a way that doesn't break existing functionality. |
@nikhilerigila09 #22668 describes the way how to find the error logs of an integration test. |
Note: This PR shouldn't be cherry-picked since it breaks the connector. Reverted in #22668. |
Fixes #22626
Motivation
Avoid CVE-2023-4586
Modifications
Upgrade debezium-oracle-connector version to 2.2.0.Final
which avoids
org.infinispan:[email protected]
which has the vulnerability and usesorg.infinispan:[email protected]
instead, which has no vulnerabilities.Verifying this change
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
doc
doc-required
doc-not-needed
doc-complete