Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][ci] Fix labeler GitHub Actions workflow, adapt to v5 configuration format #22628

Merged
merged 1 commit into from
May 1, 2024

Conversation

lhotari
Copy link
Member

@lhotari lhotari commented May 1, 2024

Motivation

labeler action was upgraded from v4 to v5 in #22620. The configuration format has changed in v5.

Modifications

adapt to v5 configuration format

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@lhotari lhotari added this to the 3.3.0 milestone May 1, 2024
@lhotari lhotari requested review from visortelle and tisonkun May 1, 2024 14:48
@lhotari lhotari self-assigned this May 1, 2024
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label May 1, 2024
Copy link
Member

@visortelle visortelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Regarding

The configuration file (path: .github/labeler.yml) was not found locally, fetching via the API
Error: Error: found unexpected type for label 'PIP' (should be array of config options)

It looks like it fetches labeler.yml from the master branch for some reason.

@lhotari
Copy link
Member Author

lhotari commented May 1, 2024

It looks like it fetches labeler.yml from the master branch for some reason.

yes, that's expected for workflows that are run on pull_request_target event. The workflow definition from the PR isn't used in that case.

@merlimat merlimat merged commit 7daebaa into apache:master May 1, 2024
50 of 54 checks passed
@lhotari lhotari deleted the lh-labeler-workflow branch May 1, 2024 18:44
hanmz pushed a commit to hanmz/pulsar that referenced this pull request Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci doc-not-needed Your PR changes do not impact docs ready-to-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants