-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix][test] Fix the flaky tests of ManagedLedgerImplUtilsTest #22611
Merged
codelipenghui
merged 1 commit into
apache:master
from
codelipenghui:penghui/fix-flaky-22572
Apr 29, 2024
Merged
[fix][test] Fix the flaky tests of ManagedLedgerImplUtilsTest #22611
codelipenghui
merged 1 commit into
apache:master
from
codelipenghui:penghui/fix-flaky-22572
Apr 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shibd
approved these changes
Apr 29, 2024
dao-jun
approved these changes
Apr 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
codelipenghui
added a commit
that referenced
this pull request
Apr 29, 2024
(cherry picked from commit 264722f)
codelipenghui
added a commit
that referenced
this pull request
Apr 29, 2024
(cherry picked from commit 264722f)
codelipenghui
added a commit
that referenced
this pull request
Apr 29, 2024
(cherry picked from commit 264722f)
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
May 13, 2024
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
May 16, 2024
hanmz
pushed a commit
to hanmz/pulsar
that referenced
this pull request
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/test
cherry-picked/branch-2.11
cherry-picked/branch-3.0
cherry-picked/branch-3.2
doc-not-needed
Your PR changes do not impact docs
ready-to-test
release/2.10.7
release/2.11.5
release/3.0.5
release/3.2.3
type/flaky-tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
If the trim ledger happened before get the
ManagedLedgerImplUtils.asyncGetLastValidPosition()
, the returned message ID will not be the message ID returned to the writer because messages are deleted by the trimming task.Modifications
Set retention policy to the managed ledger to avoid the data deletion before the verification of the test. Otherwise, the test will not cover the newly added method.
Verifying this change
It's a test change
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
doc
doc-required
doc-not-needed
doc-complete