[improve][broker] Make BrokerSelectionStrategy pluggable #22553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Motivation When users want to extend the `ExtensibleLoadManagerImpl`, the `BrokerSelectionStrategy` cannot be customized, so users have to write much duplicated code for a customized broker selection strategy. ### Modifications Add a stable interface `BrokerSelectionStrategyFactory` and implements this interface in `ExtensibleLoadManagerImpl` with the default implementation that returns a `LeastResourceUsageWithWeight` instance by default. Add `CustomBrokerSelectionStrategyTest` to show how to customize the broker selection strategy and verify it works.
BewareMyPower
requested review from
lhotari,
Technoboy-,
codelipenghui,
Demogorgon314,
poorbarcode and
heesung-sn
heesung-sn
approved these changes
Apr 22, 2024
Demogorgon314
approved these changes
Apr 23, 2024
It seems this test is flaky. I will check the failure soon. |
…d on HTTP port rather than binary port
|
The test failed because the broker selection strategy of |
BewareMyPower
deleted the
bewaremypower/broker-selection-strategy-config
branch
Technoboy-
pushed a commit
to Technoboy-/pulsar
that referenced
this pull request
Apr 24, 2024
hanmz
pushed a commit
to hanmz/pulsar
that referenced
this pull request
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When users want to extend the
ExtensibleLoadManagerImpl, theBrokerSelectionStrategycannot be customized, so users have to write much duplicated code for a customized broker selection strategy.Modifications
Add a stable interface
BrokerSelectionStrategyFactoryand implements this interface inExtensibleLoadManagerImplwith the default implementation that returns aLeastResourceUsageWithWeightinstance by default. AddCustomBrokerSelectionStrategyTestto show how to customize the broker selection strategy and verify it works.Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: