Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve] Update Oxia client to 0.1.6 #22525

Merged
merged 5 commits into from
Apr 22, 2024
Merged

Conversation

merlimat
Copy link
Contributor

Motivation

Update Oxia client 0.1.2, using regular non-shaded library.

Modifications

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@merlimat merlimat added this to the 3.3.0 milestone Apr 17, 2024
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Apr 17, 2024
Copy link
Member

@lhotari lhotari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nodece
Copy link
Member

nodece commented Apr 18, 2024

/pulsarbot rerun-failure-checks

@merlimat
Copy link
Contributor Author

There is a problem with the unshaded pom, I'm still waiting for 0.1.3 to be available on Maven Central

@nodece
Copy link
Member

nodece commented Apr 18, 2024

@merlimat Please check java.lang.NoClassDefFoundError: io/streamnative/oxia/client/metrics/api/Metrics.

@merlimat
Copy link
Contributor Author

@merlimat Please check java.lang.NoClassDefFoundError: io/streamnative/oxia/client/metrics/api/Metrics.

Yes, it's because the pom is still shaded and the dependencies are removed by maven. Waiting for 0.1.3

@merlimat merlimat changed the title [improve] Update Oxia client to 0.1.2 [improve] Update Oxia client to 0.1.6 Apr 20, 2024
@nodece
Copy link
Member

nodece commented Apr 22, 2024

LockManagerTest.acquireLocks:66 » NoClassDefFound Could not initialize class io.streamnative.oxia.proto.ListResponse

@merlimat
Copy link
Contributor Author

LockManagerTest.acquireLocks:66 » NoClassDefFound Could not initialize class io.streamnative.oxia.proto.ListResponse

This was due to protobuf version conflicts. Solved by merging with master

@merlimat merlimat merged commit c72c135 into apache:master Apr 22, 2024
47 of 49 checks passed
@merlimat merlimat deleted the update-oxia branch April 22, 2024 21:15
Technoboy- pushed a commit to Technoboy-/pulsar that referenced this pull request Apr 24, 2024
hanmz pushed a commit to hanmz/pulsar that referenced this pull request Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-not-needed Your PR changes do not impact docs ready-to-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants