[cleanup][broker] Remove unused NamespaceBundleFactory parameter when creating OwnershipCache #22482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… creating OwnershipCache ### Motivation apache#11012 removes all uses of the `NamespaceBundleFactory` field in `OwnershipCache` and apache#17768 removes that field. However, the constructor of `OwnershipCache` still has the `NamespaceBundleFactory` parameter. ### Modifications Remove that parameter from the constructor.
BewareMyPower
added
type/cleanup
BewareMyPower
requested review from
merlimat,
Technoboy-,
codelipenghui,
nodece,
dao-jun and
poorbarcode
heesung-sn
approved these changes
Apr 11, 2024
poorbarcode
approved these changes
Apr 12, 2024
gaoran10
approved these changes
Apr 12, 2024
hanmz
pushed a commit
to hanmz/pulsar
that referenced
this pull request
Feb 12, 2025
… creating OwnershipCache (apache#22482)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
#11012 removes all uses of the
NamespaceBundleFactoryfield inOwnershipCacheand #17768 removes that field. However, the constructor ofOwnershipCachestill has theNamespaceBundleFactoryparameter.Modifications
Remove that parameter from the constructor.
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: