[improve][broker] Reduce the duplicated null check for LeaderElectionService #22465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BewareMyPower
added
type/enhancement
BewareMyPower
requested review from
merlimat,
lhotari,
Technoboy-,
codelipenghui and
poorbarcode
BewareMyPower
force-pushed
the
bewaremypower/reduce-duplicate-null-check
branch
from
167360d to
6a6852d
Compare
dao-jun
approved these changes
Apr 9, 2024
Technoboy-
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
#8101 adds the null check for
LeaderElectionServiceinsearchForCandidateBrokerto avoid a null leader election service is accessed because the broker service starts before the leader election service. However, #8273 adds the null check again.Modifications
Only retain one null check.
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: