-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix][build] Fix ps command #22451
[fix][build] Fix ps command #22451
Conversation
I recommend to use the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think that bin directory should be writable. We need to modify the scripts so that it writes in some other directory.
What do you think about writing the pid file to data directory? |
It's better, but just wondering if the script |
The default could be the logs directory and letting the user override it with some env variable. |
+1, I only recommend keeping the
Write it to logs dir is a good idea.
Example: |
The |
@nodece I don't see the changes. I guess it's fine to keep |
Signed-off-by: Zixuan Liu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Zixuan Liu <[email protected]>
Motivation
ps command doesn't include
-p
option.Modifications
procps
package to fix the ps commandPULSAR_PID_DIR
environment variable, and default to/pulsar/logs
in the docker environment.Documentation
doc
doc-required
doc-not-needed
doc-complete