Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve][broker] Deprecate unused enableNamespaceIsolationUpdateOnTime config #22449

Conversation

BewareMyPower
Copy link
Contributor

Motivation

#8976 introduced an enableNamespaceIsolationUpdateOnTime config, which is useless after #15527. This config actually does not make sense because it should always be true, while it's false by default just to keep the meaningless compatibility.

Motivation

Deprecate this config and strength the
brokerNamespaceIsolationPoliciesUpdateOnTime test.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

…me config

### Motivation

apache#8976 introduced an
`enableNamespaceIsolationUpdateOnTime` config, which is useless after
apache#15527. This config actually does
not make sense because it should always be true, while it's false by
default just to keep the meaningless compatibility.

### Motivation

Deprecate this config and strength the
`brokerNamespaceIsolationPoliciesUpdateOnTime` test.
@BewareMyPower BewareMyPower added this to the 3.3.0 milestone Apr 6, 2024
@BewareMyPower BewareMyPower self-assigned this Apr 6, 2024
@github-actions github-actions bot added the doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. label Apr 6, 2024
Copy link
Member

@Demogorgon314 Demogorgon314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@BewareMyPower BewareMyPower merged commit a51bbdd into apache:master Apr 8, 2024
57 of 58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/broker doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. ready-to-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants