[improve][test] Move most flaky tests to flaky group #22433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The solution doesn't seem to work yet. When the flaky test is at the method level, it seems to inherit the test group from the class level and append the method also to the flaky test group. I'll look for a way to handle this. |
merlimat
approved these changes
Apr 4, 2024
heesung-sn
approved these changes
Apr 4, 2024
dao-jun
approved these changes
Apr 4, 2024
lhotari
added a commit
that referenced
this pull request
Apr 4, 2024
- also add solution for running test methods added to flaky group since that was missing (cherry picked from commit 5f31ec3) # Conflicts: # pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/TopicAuthZTest.java
lhotari
added a commit
that referenced
this pull request
Apr 4, 2024
- also add solution for running test methods added to flaky group since that was missing (cherry picked from commit 5f31ec3) # Conflicts: # pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/TopicAuthZTest.java # pulsar-broker/src/test/java/org/apache/pulsar/client/impl/TransactionEndToEndTest.java
lhotari
added a commit
that referenced
this pull request
Apr 4, 2024
- also add solution for running test methods added to flaky group since that was missing (cherry picked from commit 5f31ec3) # Conflicts: # pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/TopicAuthZTest.java # pulsar-broker/src/test/java/org/apache/pulsar/client/impl/TransactionEndToEndTest.java
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Apr 5, 2024
- also add solution for running test methods added to flaky group since that was missing (cherry picked from commit 5f31ec3) # Conflicts: # pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/TopicAuthZTest.java # pulsar-broker/src/test/java/org/apache/pulsar/client/impl/TransactionEndToEndTest.java (cherry picked from commit 097805d)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Apr 8, 2024
- also add solution for running test methods added to flaky group since that was missing (cherry picked from commit 5f31ec3) # Conflicts: # pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/TopicAuthZTest.java # pulsar-broker/src/test/java/org/apache/pulsar/client/impl/TransactionEndToEndTest.java (cherry picked from commit 097805d)
hanmz
pushed a commit
to hanmz/pulsar
that referenced
this pull request
Feb 12, 2025
- also add solution for running test methods added to flaky group since that was missing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation & Modifications
Move most flaky tests to flaky group until they are fixed since this causes a lot of delays and unnecessary builds.
Issues to track the moved tests:
The solution for excluding methods added to the "flaky" group at the method level with
@Test(groups = "flaky")didn't work. This PR contains changes to ensure that flaky test methods are isolated.Flaky group was previously only support in the pulsar-broker module. However some flaky tests are in the managed-ledger module. This PR contains changes to run tests in all other modules too.
Documentation
docdoc-requireddoc-not-neededdoc-complete