Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][build] Fix typo in rename script for windows cmd #22426

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

lhotari
Copy link
Member

@lhotari lhotari commented Apr 4, 2024

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@lhotari lhotari added this to the 3.3.0 milestone Apr 4, 2024
@lhotari lhotari requested a review from dao-jun April 4, 2024 08:24
@lhotari lhotari self-assigned this Apr 4, 2024
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Apr 4, 2024
Copy link
Member

@dao-jun dao-jun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dao-jun dao-jun closed this Apr 4, 2024
@dao-jun dao-jun reopened this Apr 4, 2024
@lhotari
Copy link
Member Author

lhotari commented Apr 4, 2024

@dao-jun Why are you closing and reopening PRs like this one? It's a waste of CI resources in most cases since all jobs will be rerun again. Closing and reopening PRs is fine if the PR job results have already expired or when there's a need for the PR build to pick up latest changes from master branch.

@codecov-commenter
Copy link

codecov-commenter commented Apr 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.37%. Comparing base (bbc6224) to head (8b096f7).
Report is 118 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #22426      +/-   ##
============================================
- Coverage     73.57%   73.37%   -0.21%     
+ Complexity    32624    32420     -204     
============================================
  Files          1877     1873       -4     
  Lines        139502   139692     +190     
  Branches      15299    15308       +9     
============================================
- Hits         102638   102496     -142     
- Misses        28908    29264     +356     
+ Partials       7956     7932      -24     
Flag Coverage Δ
inttests 27.15% <ø> (+2.56%) ⬆️
systests ?
unittests 73.04% <ø> (+0.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 243 files with indirect coverage changes

@dao-jun dao-jun merged commit 5390ef2 into apache:master Apr 4, 2024
91 of 105 checks passed
hanmz pushed a commit to hanmz/pulsar that referenced this pull request Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-not-needed Your PR changes do not impact docs ready-to-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants