[fix][broker][admin] Fix cannot update properties on NonDurable subscription.

[dao-jun]

Fixes #22402

Motivation

Fix cannot update properties on NonDurable subscription.

Reproduce step:

1. Create NonDurable subscription on a topic, and update subscription properties:

        PulsarClient client = PulsarClient.builder()
                .serviceUrl("pulsar://localhost:6650")
                .build();

        Producer<String> producer = client.newProducer(Schema.STRING)
                .enableBatching(false)
                .topic("persistent://public/default/test")
                .create();

        producer.send("Hello, Pulsar!");

        Reader<String> consumer = client.newReader(Schema.STRING).subscriptionName("sub").topic("persistent://public/default/test").startMessageId(MessageId.earliest).create();

        PulsarAdmin admin = PulsarAdmin.builder().serviceHttpUrl("http://localhost:8080").build();

        Map<String, String> properties = new HashMap<>();
        properties.put("foo", "bar");

        admin.topics().updateSubscriptionProperties("persistent://public/default/test", "sub", properties);

Modifications

Verifying this change

• Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

• Added integration tests for end-to-end deployment with large payloads (10MB)
• Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

• Dependencies (add or upgrade a dependency)
• The public API
• The schema
• The default values of configurations
• The threading model
• The binary protocol
• The REST endpoints
• The admin CLI options
• The metrics
• Anything that affects deployment

Documentation

• doc
• doc-required
• doc-not-needed
• doc-complete

Matching PR in forked repository

PR in forked repository:

[dao-jun]

@lhotari @codelipenghui @mattisonchao @eolivelli @Technoboy- Could you please take a look?

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.81%. Comparing base (bbc6224) to head (9d48862).
Report is 122 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff              @@
##             master   #22411      +/-   ##
============================================
+ Coverage     73.57%   73.81%   +0.23%     
+ Complexity    32624    32402     -222     
============================================
  Files          1877     1885       +8     
  Lines        139502   139818     +316     
  Branches      15299    15319      +20     
============================================
+ Hits         102638   103203     +565     
+ Misses        28908    28636     -272     
- Partials       7956     7979      +23     

Flag	Coverage Δ
inttests	26.98% <20.00%> (+2.39%)	⬆️
systests	24.67% <0.00%> (+0.34%)	⬆️
unittests	73.07% <100.00%> (+0.23%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
...che/bookkeeper/mledger/impl/ManagedCursorImpl.java	79.06% <100.00%> (-0.24%)	⬇️

... and 186 files with indirect coverage changes

[lhotari]

LGTM