-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix][build] Fix networkaddress.cache.negative.ttl config #22400
Conversation
Signed-off-by: Zixuan Liu <[email protected]>
/pulsarbot rerun-failure-checks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Zixuan Liu <[email protected]> (cherry picked from commit be012c8)
Signed-off-by: Zixuan Liu <[email protected]> (cherry picked from commit be012c8)
The problem existed before that, but in a different way. The problem has been present since Pulsar 3.0.0 . See https://github.com/apache/pulsar/blame/55788734a53acd505d97e6f8b3b4bd567603d9ce/docker/pulsar/Dockerfile#L81 . In #21207, the same pattern was replicated. This problem only became visible after #22329 changes before that, the DNS settings haven't simply been the expected ones. That might have caused quite a lot of problems. |
Signed-off-by: Zixuan Liu <[email protected]> (cherry picked from commit be012c8) (cherry picked from commit 20d35f1)
Signed-off-by: Zixuan Liu <[email protected]> (cherry picked from commit be012c8) (cherry picked from commit 20d35f1)
Motivation
#21207 introduces the
networkaddress.cache.negative.ttl config
config, which also introduces a bug that appends the "\" at the end:Documentation
doc
doc-required
doc-not-needed
doc-complete